Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

math64: Always inline u128 version of mul_u64_u64_shr()

In order to prevent the following complaint from happening, always
inline the u128 variant of mul_u64_u64_shr() -- which is what x86_64
will use.

vmlinux.o: warning: objtool: read_hv_sched_clock_tsc+0x5a: call to mul_u64_u64_shr.constprop.0() leaves .noinstr.text section

It should compile into something like:

asm("mul %[mul];"
"shrd %rdx, %rax, %cl"
: "+&a" (a)
: "c" shift, [mul] "r" (mul)
: "d");

Which is silly not to inline, but it happens.

Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org>
Tested-by: Michael Kelley <mikelley@microsoft.com> # Hyper-V
Link: https://lore.kernel.org/r/20230519102715.637420396@infradead.org

+1 -1
+1 -1
include/linux/math64.h
··· 168 168 #endif /* mul_u64_u32_shr */ 169 169 170 170 #ifndef mul_u64_u64_shr 171 - static inline u64 mul_u64_u64_shr(u64 a, u64 mul, unsigned int shift) 171 + static __always_inline u64 mul_u64_u64_shr(u64 a, u64 mul, unsigned int shift) 172 172 { 173 173 return (u64)(((unsigned __int128)a * mul) >> shift); 174 174 }