Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

Merge tag 'sunxi-drivers-for-6.12' of https://git.kernel.org/pub/scm/linux/kernel/git/sunxi/linux into soc/drivers

Allwinner SoC driver changes for 6.12

- Simplify sunxi-rsb driver probe function using dev_err_probe()

* tag 'sunxi-drivers-for-6.12' of https://git.kernel.org/pub/scm/linux/kernel/git/sunxi/linux:
bus: sunxi-rsb: Simplify code with dev_err_probe()

Link: https://lore.kernel.org/r/ZtnYUswjHdLRYq8Y@wens.tw
Signed-off-by: Arnd Bergmann <arnd@arndb.de>

+13 -21
+13 -21
drivers/bus/sunxi-rsb.c
··· 751 751 int irq, ret; 752 752 753 753 of_property_read_u32(np, "clock-frequency", &clk_freq); 754 - if (clk_freq > RSB_MAX_FREQ) { 755 - dev_err(dev, 756 - "clock-frequency (%u Hz) is too high (max = 20MHz)\n", 757 - clk_freq); 758 - return -EINVAL; 759 - } 754 + if (clk_freq > RSB_MAX_FREQ) 755 + return dev_err_probe(dev, -EINVAL, 756 + "clock-frequency (%u Hz) is too high (max = 20MHz)\n", 757 + clk_freq); 760 758 761 759 rsb = devm_kzalloc(dev, sizeof(*rsb), GFP_KERNEL); 762 760 if (!rsb) ··· 772 774 return irq; 773 775 774 776 rsb->clk = devm_clk_get(dev, NULL); 775 - if (IS_ERR(rsb->clk)) { 776 - ret = PTR_ERR(rsb->clk); 777 - dev_err(dev, "failed to retrieve clk: %d\n", ret); 778 - return ret; 779 - } 777 + if (IS_ERR(rsb->clk)) 778 + return dev_err_probe(dev, PTR_ERR(rsb->clk), 779 + "failed to retrieve clk\n"); 780 780 781 781 rsb->rstc = devm_reset_control_get(dev, NULL); 782 - if (IS_ERR(rsb->rstc)) { 783 - ret = PTR_ERR(rsb->rstc); 784 - dev_err(dev, "failed to retrieve reset controller: %d\n", ret); 785 - return ret; 786 - } 782 + if (IS_ERR(rsb->rstc)) 783 + return dev_err_probe(dev, PTR_ERR(rsb->rstc), 784 + "failed to retrieve reset controller\n"); 787 785 788 786 init_completion(&rsb->complete); 789 787 mutex_init(&rsb->lock); 790 788 791 789 ret = devm_request_irq(dev, irq, sunxi_rsb_irq, 0, RSB_CTRL_NAME, rsb); 792 - if (ret) { 793 - dev_err(dev, "can't register interrupt handler irq %d: %d\n", 794 - irq, ret); 795 - return ret; 796 - } 790 + if (ret) 791 + return dev_err_probe(dev, ret, 792 + "can't register interrupt handler irq %d\n", irq); 797 793 798 794 ret = sunxi_rsb_hw_init(rsb); 799 795 if (ret)