Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

gpio: twl4030: Use devm_gpiochip_add_data() to simplify remove path

Use devm version of gpiochip add function to handle removal for us.

Signed-off-by: Andrew Davis <afd@ti.com>
Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>

authored by

Andrew Davis and committed by
Bartosz Golaszewski
fbc8ab2c 2148a7ac

+3 -20
+3 -20
drivers/gpio/gpio-twl4030.c
··· 492 492 return omap_twl_info; 493 493 } 494 494 495 - /* Cannot use as gpio_twl4030_probe() calls us */ 496 - static int gpio_twl4030_remove(struct platform_device *pdev) 497 - { 498 - struct gpio_twl4030_priv *priv = platform_get_drvdata(pdev); 499 - 500 - gpiochip_remove(&priv->gpio_chip); 501 - 502 - /* REVISIT no support yet for deregistering all the IRQs */ 503 - WARN_ON(!is_module()); 504 - return 0; 505 - } 506 - 507 495 static int gpio_twl4030_probe(struct platform_device *pdev) 508 496 { 509 497 struct twl4030_gpio_platform_data *pdata = dev_get_platdata(&pdev->dev); ··· 565 577 if (pdata->use_leds) 566 578 priv->gpio_chip.ngpio += 2; 567 579 568 - ret = gpiochip_add_data(&priv->gpio_chip, priv); 580 + ret = devm_gpiochip_add_data(&pdev->dev, &priv->gpio_chip, priv); 569 581 if (ret < 0) { 570 582 dev_err(&pdev->dev, "could not register gpiochip, %d\n", ret); 571 583 priv->gpio_chip.ngpio = 0; 572 - gpio_twl4030_remove(pdev); 573 - goto out; 584 + return ret; 574 585 } 575 - 576 - platform_set_drvdata(pdev, priv); 577 586 578 587 if (pdata->setup) { 579 588 int status; ··· 581 596 dev_dbg(&pdev->dev, "setup --> %d\n", status); 582 597 } 583 598 584 - out: 585 - return ret; 599 + return 0; 586 600 } 587 601 588 602 static const struct of_device_id twl_gpio_match[] = { ··· 599 615 .of_match_table = twl_gpio_match, 600 616 }, 601 617 .probe = gpio_twl4030_probe, 602 - .remove = gpio_twl4030_remove, 603 618 }; 604 619 605 620 static int __init gpio_twl4030_init(void)