tjh.dev / kernel
Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux
fork atom

rt2x00: never disable multicast because it disables broadcast too

On rt73 and rt61 disabling reception of multicast packets also disables
broadcast traffic which we never want to do. Therefore we should never
disable multicast.

Signed-off-by: Adam Baker <linux@baker-net.org.uk>
Signed-off-by: Ivo van Doorn <IvDoorn@gmail.com>
Signed-off-by: John W. Linville <linville@tuxdriver.com>

authored by Adam Baker and committed by John W. Linville fbb0a27a 5f0547c2

+4 -4
unified split
+2 -2
drivers/net/wireless/rt2x00/rt61pci.c
··· 2302 * Apply some rules to the filters: 2303 * - Some filters imply different filters to be set. 2304 * - Some things we can't filter out at all. 2305 */ 2306 - if (mc_count) 2307 - *total_flags |= FIF_ALLMULTI; 2308 if (*total_flags & FIF_OTHER_BSS || 2309 *total_flags & FIF_PROMISC_IN_BSS) 2310 *total_flags |= FIF_PROMISC_IN_BSS | FIF_OTHER_BSS;
··· 2302 * Apply some rules to the filters: 2303 * - Some filters imply different filters to be set. 2304 * - Some things we can't filter out at all. 2305 + * - Multicast filter seems to kill broadcast traffic so never use it. 2306 */ 2307 + *total_flags |= FIF_ALLMULTI; 2308 if (*total_flags & FIF_OTHER_BSS || 2309 *total_flags & FIF_PROMISC_IN_BSS) 2310 *total_flags |= FIF_PROMISC_IN_BSS | FIF_OTHER_BSS;
+2 -2
drivers/net/wireless/rt2x00/rt73usb.c
··· 1869 * Apply some rules to the filters: 1870 * - Some filters imply different filters to be set. 1871 * - Some things we can't filter out at all. 1872 */ 1873 - if (mc_count) 1874 - *total_flags |= FIF_ALLMULTI; 1875 if (*total_flags & FIF_OTHER_BSS || 1876 *total_flags & FIF_PROMISC_IN_BSS) 1877 *total_flags |= FIF_PROMISC_IN_BSS | FIF_OTHER_BSS;
··· 1869 * Apply some rules to the filters: 1870 * - Some filters imply different filters to be set. 1871 * - Some things we can't filter out at all. 1872 + * - Multicast filter seems to kill broadcast traffic so never use it. 1873 */ 1874 + *total_flags |= FIF_ALLMULTI; 1875 if (*total_flags & FIF_OTHER_BSS || 1876 *total_flags & FIF_PROMISC_IN_BSS) 1877 *total_flags |= FIF_PROMISC_IN_BSS | FIF_OTHER_BSS;