Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

ACPI: utils: Clean up printing messages

Replace all of the ACPI_DEBUG_PRINT() instances in utils.c with
pr_debug() and acpi_handle_debug(), drop the _COMPONENT and
ACPI_MODULE_NAME() definitions that are not used any more and
replace direct printk() invocations with pr_debug() calls (the log
level in there is way excessive).

Also add a special pr_fmt() definition, but this only affects the
pr_debug() messages mentioned above.

Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>

+18 -38
+18 -38
drivers/acpi/utils.c
··· 6 6 * Copyright (C) 2001, 2002 Paul Diefenbaugh <paul.s.diefenbaugh@intel.com> 7 7 */ 8 8 9 + #define pr_fmt(fmt) "ACPI: utils: " fmt 10 + 9 11 #include <linux/kernel.h> 10 12 #include <linux/module.h> 11 13 #include <linux/slab.h> ··· 20 18 #include "internal.h" 21 19 #include "sleep.h" 22 20 23 - #define _COMPONENT ACPI_BUS_COMPONENT 24 - ACPI_MODULE_NAME("utils"); 25 - 26 21 /* -------------------------------------------------------------------------- 27 22 Object Evaluation Helpers 28 23 -------------------------------------------------------------------------- */ 29 - static void 30 - acpi_util_eval_error(acpi_handle h, acpi_string p, acpi_status s) 24 + static void acpi_util_eval_error(acpi_handle h, acpi_string p, acpi_status s) 31 25 { 32 - #ifdef ACPI_DEBUG_OUTPUT 33 - char prefix[80] = {'\0'}; 34 - struct acpi_buffer buffer = {sizeof(prefix), prefix}; 35 - acpi_get_name(h, ACPI_FULL_PATHNAME, &buffer); 36 - ACPI_DEBUG_PRINT((ACPI_DB_INFO, "Evaluate [%s.%s]: %s\n", 37 - (char *) prefix, p, acpi_format_exception(s))); 38 - #else 39 - return; 40 - #endif 26 + acpi_handle_debug(h, "Evaluate [%s]: %s\n", p, acpi_format_exception(s)); 41 27 } 42 28 43 29 acpi_status ··· 43 53 44 54 if (!package || (package->type != ACPI_TYPE_PACKAGE) 45 55 || (package->package.count < 1)) { 46 - printk(KERN_WARNING PREFIX "Invalid package argument\n"); 56 + pr_debug("Invalid package argument\n"); 47 57 return AE_BAD_PARAMETER; 48 58 } 49 59 50 60 if (!format || !format->pointer || (format->length < 1)) { 51 - printk(KERN_WARNING PREFIX "Invalid format argument\n"); 61 + pr_debug("Invalid format argument\n"); 52 62 return AE_BAD_PARAMETER; 53 63 } 54 64 55 65 if (!buffer) { 56 - printk(KERN_WARNING PREFIX "Invalid buffer argument\n"); 66 + pr_debug("Invalid buffer argument\n"); 57 67 return AE_BAD_PARAMETER; 58 68 } 59 69 60 70 format_count = (format->length / sizeof(char)) - 1; 61 71 if (format_count > package->package.count) { 62 - printk(KERN_WARNING PREFIX "Format specifies more objects [%d]" 63 - " than exist in package [%d].\n", 64 - format_count, package->package.count); 72 + pr_debug("Format specifies more objects [%d] than present [%d]\n", 73 + format_count, package->package.count); 65 74 return AE_BAD_DATA; 66 75 } 67 76 ··· 88 99 tail_offset += sizeof(char *); 89 100 break; 90 101 default: 91 - printk(KERN_WARNING PREFIX "Invalid package element" 92 - " [%d]: got number, expecting" 93 - " [%c]\n", 94 - i, format_string[i]); 102 + pr_debug("Invalid package element [%d]: got number, expected [%c]\n", 103 + i, format_string[i]); 95 104 return AE_BAD_DATA; 96 105 } 97 106 break; ··· 110 123 tail_offset += sizeof(u8 *); 111 124 break; 112 125 default: 113 - printk(KERN_WARNING PREFIX "Invalid package element" 114 - " [%d] got string/buffer," 115 - " expecting [%c]\n", 116 - i, format_string[i]); 126 + pr_debug("Invalid package element [%d] got string/buffer, expected [%c]\n", 127 + i, format_string[i]); 117 128 return AE_BAD_DATA; 118 129 } 119 130 break; ··· 122 137 tail_offset += sizeof(void *); 123 138 break; 124 139 default: 125 - printk(KERN_WARNING PREFIX "Invalid package element" 126 - " [%d] got reference," 127 - " expecting [%c]\n", 128 - i, format_string[i]); 140 + pr_debug("Invalid package element [%d] got reference, expected [%c]\n", 141 + i, format_string[i]); 129 142 return AE_BAD_DATA; 130 143 } 131 144 break; 132 145 133 146 case ACPI_TYPE_PACKAGE: 134 147 default: 135 - ACPI_DEBUG_PRINT((ACPI_DB_INFO, 136 - "Found unsupported element at index=%d\n", 137 - i)); 148 + pr_debug("Unsupported element at index=%d\n", i); 138 149 /* TBD: handle nested packages... */ 139 150 return AE_SUPPORT; 140 151 } ··· 270 289 271 290 *data = element.integer.value; 272 291 273 - ACPI_DEBUG_PRINT((ACPI_DB_INFO, "Return value [%llu]\n", *data)); 292 + acpi_handle_debug(handle, "Return value [%llu]\n", *data); 274 293 275 294 return AE_OK; 276 295 } ··· 344 363 /* Get the acpi_handle. */ 345 364 346 365 list->handles[i] = element->reference.handle; 347 - ACPI_DEBUG_PRINT((ACPI_DB_INFO, "Found reference [%p]\n", 348 - list->handles[i])); 366 + acpi_handle_debug(list->handles[i], "Found in reference list\n"); 349 367 } 350 368 351 369 end: