Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

net: ethernet: mtk_eth_soc: fix wrong use of new helper function

In function mtk_foe_entry_set_vlan() the call to field accessor macro
FIELD_GET(MTK_FOE_IB1_BIND_VLAN_LAYER, entry->ib1)
has been wrongly replaced by
mtk_prep_ib1_vlan_layer(eth, entry->ib1)

Use correct helper function mtk_get_ib1_vlan_layer instead.

Reported-by: Chen Minqiang <ptpt52@gmail.com>
Fixes: 03a3180e5c09e1 ("net: ethernet: mtk_eth_soc: introduce flow offloading support for mt7986")
Signed-off-by: Daniel Golle <daniel@makrotopia.org>
Acked-by: Lorenzo Bianconi <lorenzo@kernel.org>
Link: https://lore.kernel.org/r/YzBp+Kk04CFDys4L@makrotopia.org
Signed-off-by: Jakub Kicinski <kuba@kernel.org>

authored by

Daniel Golle and committed by
Jakub Kicinski
fb7da771 5591b021

+1 -1
+1 -1
drivers/net/ethernet/mediatek/mtk_ppe.c
··· 337 337 { 338 338 struct mtk_foe_mac_info *l2 = mtk_foe_entry_l2(eth, entry); 339 339 340 - switch (mtk_prep_ib1_vlan_layer(eth, entry->ib1)) { 340 + switch (mtk_get_ib1_vlan_layer(eth, entry->ib1)) { 341 341 case 0: 342 342 entry->ib1 |= mtk_get_ib1_vlan_tag_mask(eth) | 343 343 mtk_prep_ib1_vlan_layer(eth, 1);