Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

staging: fieldbus: use sysfs_emit() in show functions

The show() methods should only use sysfs_emit() when formatting values
to be returned to the user space.
Ref: Documentation/filesystems/sysfs.rst
Issue identified by coccicheck.

Signed-off-by: Deepak R Varma <drv@mailo.com>
Link: https://lore.kernel.org/r/Y2uEIzebbM/Fs5Jz@qemulion
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

authored by

Deepak R Varma and committed by
Greg Kroah-Hartman
fb7d5ebe 8ce25654

+7 -10
+7 -10
drivers/staging/fieldbus/dev_core.c
··· 28 28 { 29 29 struct fieldbus_dev *fb = dev_get_drvdata(dev); 30 30 31 - return sprintf(buf, "%d\n", !!fb->online); 31 + return sysfs_emit(buf, "%d\n", !!fb->online); 32 32 } 33 33 static DEVICE_ATTR_RO(online); 34 34 ··· 39 39 40 40 if (!fb->enable_get) 41 41 return -EINVAL; 42 - return sprintf(buf, "%d\n", !!fb->enable_get(fb)); 42 + return sysfs_emit(buf, "%d\n", !!fb->enable_get(fb)); 43 43 } 44 44 45 45 static ssize_t enabled_store(struct device *dev, struct device_attribute *attr, ··· 66 66 { 67 67 struct fieldbus_dev *fb = dev_get_drvdata(dev); 68 68 69 - /* 70 - * card_name was provided by child driver, could potentially be long. 71 - * protect against buffer overrun. 72 - */ 73 - return snprintf(buf, PAGE_SIZE, "%s\n", fb->card_name); 69 + /* card_name was provided by child driver. */ 70 + return sysfs_emit(buf, "%s\n", fb->card_name); 74 71 } 75 72 static DEVICE_ATTR_RO(card_name); 76 73 ··· 76 79 { 77 80 struct fieldbus_dev *fb = dev_get_drvdata(dev); 78 81 79 - return sprintf(buf, "%zu\n", fb->read_area_sz); 82 + return sysfs_emit(buf, "%zu\n", fb->read_area_sz); 80 83 } 81 84 static DEVICE_ATTR_RO(read_area_size); 82 85 ··· 85 88 { 86 89 struct fieldbus_dev *fb = dev_get_drvdata(dev); 87 90 88 - return sprintf(buf, "%zu\n", fb->write_area_sz); 91 + return sysfs_emit(buf, "%zu\n", fb->write_area_sz); 89 92 } 90 93 static DEVICE_ATTR_RO(write_area_size); 91 94 ··· 113 116 break; 114 117 } 115 118 116 - return sprintf(buf, "%s\n", t); 119 + return sysfs_emit(buf, "%s\n", t); 117 120 } 118 121 static DEVICE_ATTR_RO(fieldbus_type); 119 122