Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

usb: dwc3: dwc3-octeon: Verify clock divider

Although valid USB clock divider will be calculated for all valid
Octeon core frequencies, make code formally correct limiting
divider not to be greater that 7 so it fits into H_CLKDIV_SEL
field.

Signed-off-by: Ladislav Michl <ladis@linux-mips.org>
Reported-by: Linux Kernel Functional Testing <lkft@linaro.org>
Closes: https://qa-reports.linaro.org/lkft/linux-next-master/build/next-20230808/testrun/18882876/suite/build/test/gcc-8-cavium_octeon_defconfig/log
Acked-by: Thinh Nguyen <Thinh.Nguyen@synopsys.com>
Link: https://lore.kernel.org/r/ZNIM7tlBNdHFzXZG@lenoch
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

authored by

Ladislav Michl and committed by
Greg Kroah-Hartman
fb57f829 ff33299e

+6 -2
+6 -2
drivers/usb/dwc3/dwc3-octeon.c
··· 251 251 while (div < ARRAY_SIZE(clk_div)) { 252 252 uint64_t rate = octeon_get_io_clock_rate() / clk_div[div]; 253 253 if (rate <= 300000000 && rate >= 150000000) 254 - break; 254 + return div; 255 255 div++; 256 256 } 257 257 258 - return div; 258 + return -EINVAL; 259 259 } 260 260 261 261 static int dwc3_octeon_setup(struct dwc3_octeon *octeon, ··· 289 289 290 290 /* Step 4b: Select controller clock frequency. */ 291 291 div = dwc3_octeon_get_divider(); 292 + if (div < 0) { 293 + dev_err(dev, "clock divider invalid\n"); 294 + return div; 295 + } 292 296 val = dwc3_octeon_readq(uctl_ctl_reg); 293 297 val &= ~USBDRD_UCTL_CTL_H_CLKDIV_SEL; 294 298 val |= FIELD_PREP(USBDRD_UCTL_CTL_H_CLKDIV_SEL, div);