Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

tty: Fix the keyboard led light display problem

Use the "ctrl+alt+Fn" key combination to switch the system from tty to
desktop or switch the system from desktop to tty. After the switch is
completed, it is found that the state of the keyboard lock is
inconsistent with the state of the keyboard Led light.The reasons are
as follows:

* The desktop environment (Xorg and other services) is bound to a tty
(assuming it is tty1), and the kb->kbdmode attribute value of tty1
will be set to VC_OFF. According to the current code logic, in the
desktop environment, the values of ledstate and kb->ledflagstate
of tty1 will not be modified anymore, so they are always 0.

* When switching between each tty, the final value of ledstate set by
the previous tty is compared with the kb->ledflagstate value of the
current tty to determine whether to set the state of the keyboard
light. The process of switching between desktop and tty is also the
process of switching between tty1 and other ttys. There are two
situations:

- (1) In the desktop environment, tty1 will not set the ledstate,
which will cause when switching from the desktop to other ttys,
if the desktop lights up the keyboard's led, after the switch is
completed, the keyboard's led light will always be on;

- (2) When switching from another tty to the desktop, this
mechanism will trigger tty1 to set the led state. If other tty
lights up the led of the keyboard before switching to the desktop,
the led will be forcibly turned off. This situation should
be avoided.

* The current patch is to solve these problems: When VT is switched,
the keyboard led needs to be set once.Ensure that after the
switch is completed, the state of the keyboard LED is consistent
with the state of the keyboard lock.

Suggested-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Reviewed-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Signed-off-by: lianzhi chang <changlianzhi@uniontech.com>
Link: https://lore.kernel.org/r/20211215125125.10554-1-changlianzhi@uniontech.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

authored by

lianzhi chang and committed by
Greg Kroah-Hartman
fb09d0ac 34de6666

+12
+12
drivers/tty/vt/keyboard.c
··· 153 153 154 154 static unsigned int ledstate = -1U; /* undefined */ 155 155 static unsigned char ledioctl; 156 + static bool vt_switch; 156 157 157 158 /* 158 159 * Notifier list for console keyboard events ··· 415 414 { 416 415 unsigned long flags; 417 416 417 + /* 418 + * When VT is switched, the keyboard led needs to be set once. 419 + * Ensure that after the switch is completed, the state of the 420 + * keyboard LED is consistent with the state of the keyboard lock. 421 + */ 422 + vt_switch = true; 418 423 set_leds(); 419 424 420 425 spin_lock_irqsave(&kbd_event_lock, flags); ··· 1261 1254 leds = getleds(); 1262 1255 leds |= (unsigned int)kbd->lockstate << 8; 1263 1256 spin_unlock_irqrestore(&led_lock, flags); 1257 + 1258 + if (vt_switch) { 1259 + ledstate = ~leds; 1260 + vt_switch = false; 1261 + } 1264 1262 1265 1263 if (leds != ledstate) { 1266 1264 kbd_propagate_led_state(ledstate, leds);