Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

ice: print opcode when printing controlq errors

To help aid in debugging, display the command opcode in debug messages
that print an error code. This makes it easier to see what command
failed if only ICE_DBG_AQ_MSG is enabled.

Signed-off-by: Jacob Keller <jacob.e.keller@intel.com>
Tested-by: Andrew Bowers <andrewx.bowers@intel.com>
Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>

authored by

Jacob Keller and committed by
Jeff Kirsher
fb0254b2 faa01721

+4 -2
+4 -2
drivers/net/ethernet/intel/ice/ice_controlq.c
··· 1017 1017 retval = le16_to_cpu(desc->retval); 1018 1018 if (retval) { 1019 1019 ice_debug(hw, ICE_DBG_AQ_MSG, 1020 - "Control Send Queue command completed with error 0x%x\n", 1020 + "Control Send Queue command 0x%04X completed with error 0x%X\n", 1021 + le16_to_cpu(desc->opcode), 1021 1022 retval); 1022 1023 1023 1024 /* strip off FW internal code */ ··· 1122 1121 if (flags & ICE_AQ_FLAG_ERR) { 1123 1122 ret_code = ICE_ERR_AQ_ERROR; 1124 1123 ice_debug(hw, ICE_DBG_AQ_MSG, 1125 - "Control Receive Queue Event received with error 0x%x\n", 1124 + "Control Receive Queue Event 0x%04X received with error 0x%X\n", 1125 + le16_to_cpu(desc->opcode), 1126 1126 cq->rq_last_status); 1127 1127 } 1128 1128 memcpy(&e->desc, desc, sizeof(e->desc));