Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

Input: goodix - disable IRQs while suspended

We should not try to do any i2c transfers before the controller is
resumed (which happens before our resume method gets called).

So we need to disable our IRQ while suspended to enforce this. The
code paths for devices with GPIOs for the int and reset pins already
disable the IRQ the through goodix_free_irq().

This commit also disables the IRQ while suspended for devices without
GPIOs for the int and reset pins.

This fixes the i2c bus sometimes getting stuck after a suspend/resume
causing the touchscreen to sometimes not work after a suspend/resume.
This has been tested on a GPD pocked device.

BugLink: https://github.com/nexus511/gpd-ubuntu-packages/issues/10
BugLink: https://www.reddit.com/r/GPDPocket/comments/7niut2/fix_for_broken_touch_after_resume_all_linux/
Tested-by: Hans de Goede <hdegoede@redhat.com>
Signed-off-by: Hans de Goede <hdegoede@redhat.com>
Reviewed-by: Bastien Nocera <hadess@hadess.net>
Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>

authored by

Hans de Goede and committed by
Dmitry Torokhov
faec44b6 152194fe

+6 -2
+6 -2
drivers/input/touchscreen/goodix.c
··· 878 878 int error; 879 879 880 880 /* We need gpio pins to suspend/resume */ 881 - if (!ts->gpiod_int || !ts->gpiod_rst) 881 + if (!ts->gpiod_int || !ts->gpiod_rst) { 882 + disable_irq(client->irq); 882 883 return 0; 884 + } 883 885 884 886 wait_for_completion(&ts->firmware_loading_complete); 885 887 ··· 921 919 struct goodix_ts_data *ts = i2c_get_clientdata(client); 922 920 int error; 923 921 924 - if (!ts->gpiod_int || !ts->gpiod_rst) 922 + if (!ts->gpiod_int || !ts->gpiod_rst) { 923 + enable_irq(client->irq); 925 924 return 0; 925 + } 926 926 927 927 /* 928 928 * Exit sleep mode by outputting HIGH level to INT pin