tjh.dev / kernel
Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux
fork atom

cris: re-use helpers to dump data in hex format

There are native helpers such as print_hex_byte() and %*ph specifier to dump
data in hex format. Re-use them instead of a custom approach.

Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Signed-off-by: Jesper Nilsson <jespern@axis.com>

authored by

Andy Shevchenko and committed by
Jesper Nilsson fad5a06b ab28e96f

+6 -34
+6 -34
arch/cris/arch-v32/drivers/axisflashmap.c
··· 361 361 362 362 #if 0 /* Dump flash memory so we can see what is going on */ 363 363 if (main_mtd) { 364 - int sectoraddr, i; 364 + int sectoraddr; 365 365 for (sectoraddr = 0; sectoraddr < 2*65536+4096; 366 366 sectoraddr += PAGESIZE) { 367 367 main_mtd->read(main_mtd, sectoraddr, PAGESIZE, &len, ··· 369 369 printk(KERN_INFO 370 370 "Sector at %d (length %d):\n", 371 371 sectoraddr, len); 372 - for (i = 0; i < PAGESIZE; i += 16) { 373 - printk(KERN_INFO 374 - "%02x %02x %02x %02x " 375 - "%02x %02x %02x %02x " 376 - "%02x %02x %02x %02x " 377 - "%02x %02x %02x %02x\n", 378 - page[i] & 255, page[i+1] & 255, 379 - page[i+2] & 255, page[i+3] & 255, 380 - page[i+4] & 255, page[i+5] & 255, 381 - page[i+6] & 255, page[i+7] & 255, 382 - page[i+8] & 255, page[i+9] & 255, 383 - page[i+10] & 255, page[i+11] & 255, 384 - page[i+12] & 255, page[i+13] & 255, 385 - page[i+14] & 255, page[i+15] & 255); 386 - } 372 + print_hex_dump(KERN_INFO, "", DUMP_PREFIX_NONE, 16, 1, page, PAGESIZE, false); 387 373 } 388 374 } 389 375 #endif ··· 403 417 404 418 #if 0 /* Dump partition table so we can see what is going on */ 405 419 printk(KERN_INFO 406 - "axisflashmap: flash read %d bytes at 0x%08x, data: " 407 - "%02x %02x %02x %02x %02x %02x %02x %02x\n", 408 - len, CONFIG_ETRAX_PTABLE_SECTOR, 409 - page[0] & 255, page[1] & 255, 410 - page[2] & 255, page[3] & 255, 411 - page[4] & 255, page[5] & 255, 412 - page[6] & 255, page[7] & 255); 420 + "axisflashmap: flash read %d bytes at 0x%08x, data: %8ph\n", 421 + len, CONFIG_ETRAX_PTABLE_SECTOR, page); 413 422 printk(KERN_INFO 414 - "axisflashmap: partition table offset %d, data: " 415 - "%02x %02x %02x %02x %02x %02x %02x %02x\n", 416 - PARTITION_TABLE_OFFSET, 417 - page[PARTITION_TABLE_OFFSET+0] & 255, 418 - page[PARTITION_TABLE_OFFSET+1] & 255, 419 - page[PARTITION_TABLE_OFFSET+2] & 255, 420 - page[PARTITION_TABLE_OFFSET+3] & 255, 421 - page[PARTITION_TABLE_OFFSET+4] & 255, 422 - page[PARTITION_TABLE_OFFSET+5] & 255, 423 - page[PARTITION_TABLE_OFFSET+6] & 255, 424 - page[PARTITION_TABLE_OFFSET+7] & 255); 423 + "axisflashmap: partition table offset %d, data: %8ph\n", 424 + PARTITION_TABLE_OFFSET, page + PARTITION_TABLE_OFFSET); 425 425 #endif 426 426 } 427 427