Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

drm/msm/dp: Drop now unused hpd_high member

Since '8ede2ecc3e5e ("drm/msm/dp: Add DP compliance tests on Snapdragon
Chipsets")' the hpd_high member of struct dp_usbpd has been write-only.

Let's clean up the code a little bit by removing the writes as well.

Signed-off-by: Bjorn Andersson <bjorn.andersson@linaro.org>
Reviewed-by: Stephen Boyd <swboyd@chromium.org>
Link: https://lore.kernel.org/r/20211106172246.2597431-1-bjorn.andersson@linaro.org
Signed-off-by: Rob Clark <robdclark@chromium.org>

authored by

Bjorn Andersson and committed by
Rob Clark
fabae667 a630ac68

-10
-6
drivers/gpu/drm/msm/dp/dp_display.c
··· 531 531 532 532 dp->hpd_state = ST_CONNECT_PENDING; 533 533 534 - hpd->hpd_high = 1; 535 - 536 534 ret = dp_display_usbpd_configure_cb(&dp->pdev->dev); 537 535 if (ret) { /* link train failed */ 538 - hpd->hpd_high = 0; 539 536 dp->hpd_state = ST_DISCONNECTED; 540 537 541 538 if (ret == -ECONNRESET) { /* cable unplugged */ ··· 609 612 /* triggered by irq_hdp with sink_count = 0 */ 610 613 if (dp->link->sink_count == 0) { 611 614 dp_ctrl_off_phy(dp->ctrl); 612 - hpd->hpd_high = 0; 613 615 dp->core_initialized = false; 614 616 } 615 617 mutex_unlock(&dp->event_mutex); ··· 631 635 632 636 /* disable HPD plug interrupts */ 633 637 dp_catalog_hpd_config_intr(dp->catalog, DP_DP_HPD_PLUG_INT_MASK, false); 634 - 635 - hpd->hpd_high = 0; 636 638 637 639 /* 638 640 * We don't need separate work for disconnect as
-2
drivers/gpu/drm/msm/dp/dp_hpd.c
··· 32 32 hpd_priv = container_of(dp_usbpd, struct dp_hpd_private, 33 33 dp_usbpd); 34 34 35 - dp_usbpd->hpd_high = hpd; 36 - 37 35 if (!hpd_priv->dp_cb || !hpd_priv->dp_cb->configure 38 36 || !hpd_priv->dp_cb->disconnect) { 39 37 pr_err("hpd dp_cb not initialized\n");
-2
drivers/gpu/drm/msm/dp/dp_hpd.h
··· 26 26 * @multi_func: multi-function preferred 27 27 * @usb_config_req: request to switch to usb 28 28 * @exit_dp_mode: request exit from displayport mode 29 - * @hpd_high: Hot Plug Detect signal is high. 30 29 * @hpd_irq: Change in the status since last message 31 30 * @alt_mode_cfg_done: bool to specify alt mode status 32 31 * @debug_en: bool to specify debug mode ··· 38 39 bool multi_func; 39 40 bool usb_config_req; 40 41 bool exit_dp_mode; 41 - bool hpd_high; 42 42 bool hpd_irq; 43 43 bool alt_mode_cfg_done; 44 44 bool debug_en;