Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

pwm: omap-dmtimer: Don't check the return code of pwmchip_remove()

pwmchip_remove() returns always 0. Don't use the value to make it
possible to eventually change the function to return void. Also the
driver core ignores the return value of pwm_omap_dmtimer_remove()
and considers the device removed anyhow. So returning early results
in a resource leak.

Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Signed-off-by: Thierry Reding <thierry.reding@gmail.com>

authored by

Uwe Kleine-König and committed by
Thierry Reding
faaa2222 9b7b5736

+1 -4
+1 -4
drivers/pwm/pwm-omap-dmtimer.c
··· 444 444 static int pwm_omap_dmtimer_remove(struct platform_device *pdev) 445 445 { 446 446 struct pwm_omap_dmtimer_chip *omap = platform_get_drvdata(pdev); 447 - int ret; 448 447 449 - ret = pwmchip_remove(&omap->chip); 450 - if (ret) 451 - return ret; 448 + pwmchip_remove(&omap->chip); 452 449 453 450 if (pm_runtime_active(&omap->dm_timer_pdev->dev)) 454 451 omap->pdata->stop(omap->dm_timer);