Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

soc: aspeed: lpc-snoop: Use dev_err_probe() where possible

Exploit that it returns the provided error to eliminate some lines, and
return the actual error involved rather than -ENODEV.

Link: https://patch.msgid.link/20250616-aspeed-lpc-snoop-fixes-v2-8-3cdd59c934d3@codeconstruct.com.au
Acked-by: Jean Delvare <jdelvare@suse.de>
Signed-off-by: Andrew Jeffery <andrew@codeconstruct.com.au>

+5 -10
+5 -10
drivers/soc/aspeed/aspeed-lpc-snoop.c
··· 12 12 13 13 #include <linux/bitops.h> 14 14 #include <linux/clk.h> 15 + #include <linux/dev_printk.h> 15 16 #include <linux/interrupt.h> 16 17 #include <linux/fs.h> 17 18 #include <linux/kfifo.h> ··· 316 315 } 317 316 318 317 lpc_snoop->regmap = syscon_node_to_regmap(np); 319 - if (IS_ERR(lpc_snoop->regmap)) { 320 - dev_err(dev, "Couldn't get regmap\n"); 321 - return -ENODEV; 322 - } 318 + if (IS_ERR(lpc_snoop->regmap)) 319 + return dev_err_probe(dev, PTR_ERR(lpc_snoop->regmap), "Couldn't get regmap\n"); 323 320 324 321 dev_set_drvdata(&pdev->dev, lpc_snoop); 325 322 ··· 328 329 } 329 330 330 331 lpc_snoop->clk = devm_clk_get_enabled(dev, NULL); 331 - if (IS_ERR(lpc_snoop->clk)) { 332 - rc = PTR_ERR(lpc_snoop->clk); 333 - if (rc != -EPROBE_DEFER) 334 - dev_err(dev, "couldn't get clock\n"); 335 - return rc; 336 - } 332 + if (IS_ERR(lpc_snoop->clk)) 333 + return dev_err_probe(dev, PTR_ERR(lpc_snoop->clk), "couldn't get clock"); 337 334 338 335 rc = aspeed_lpc_snoop_config_irq(lpc_snoop, pdev); 339 336 if (rc)