tjh.dev
Linux kernel mirror (for testing)
git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel
os
linux
infiniband: umode_t noise, including open-coded S_ISDIR()
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
+6
-6
+3
-3
drivers/infiniband/hw/ipath/ipath_fs.c
+3
-3
drivers/infiniband/hw/ipath/ipath_fs.c
···
46
46
static struct super_block *ipath_super;
47
47
48
48
static int ipathfs_mknod(struct inode *dir, struct dentry *dentry,
49
-
int mode, const struct file_operations *fops,
49
+
umode_t mode, const struct file_operations *fops,
50
50
void *data)
51
51
{
52
52
int error;
···
61
61
inode->i_mode = mode;
62
62
inode->i_atime = inode->i_mtime = inode->i_ctime = CURRENT_TIME;
63
63
inode->i_private = data;
64
-
if ((mode & S_IFMT) == S_IFDIR) {
64
+
if (S_ISDIR(mode)) {
65
65
inode->i_op = &simple_dir_inode_operations;
66
66
inc_nlink(inode);
67
67
inc_nlink(dir);
···
76
76
return error;
77
77
}
78
78
79
-
static int create_file(const char *name, mode_t mode,
79
+
static int create_file(const char *name, umode_t mode,
80
80
struct dentry *parent, struct dentry **dentry,
81
81
const struct file_operations *fops, void *data)
82
82
{
+3
-3
drivers/infiniband/hw/qib/qib_fs.c
+3
-3
drivers/infiniband/hw/qib/qib_fs.c
···
47
47
#define private2dd(file) ((file)->f_dentry->d_inode->i_private)
48
48
49
49
static int qibfs_mknod(struct inode *dir, struct dentry *dentry,
50
-
int mode, const struct file_operations *fops,
50
+
umode_t mode, const struct file_operations *fops,
51
51
void *data)
52
52
{
53
53
int error;
···
67
67
inode->i_mtime = inode->i_atime;
68
68
inode->i_ctime = inode->i_atime;
69
69
inode->i_private = data;
70
-
if ((mode & S_IFMT) == S_IFDIR) {
70
+
if (S_ISDIR(mode)) {
71
71
inode->i_op = &simple_dir_inode_operations;
72
72
inc_nlink(inode);
73
73
inc_nlink(dir);
···
82
82
return error;
83
83
}
84
84
85
-
static int create_file(const char *name, mode_t mode,
85
+
static int create_file(const char *name, umode_t mode,
86
86
struct dentry *parent, struct dentry **dentry,
87
87
const struct file_operations *fops, void *data)
88
88
{