Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

net: plip: fix break; causing plip to never transmit

Since commit
71ae2cb30531 ("net: plip: Fix fall-through warnings for Clang")

plip was not able to send any packets, this patch replaces one
unintended break; with fallthrough; which was originally missed by
commit 9525d69a3667 ("net: plip: mark expected switch fall-throughs").

I have verified with a real hardware PLIP connection that everything
works once again after applying this patch.

Fixes: 71ae2cb30531 ("net: plip: Fix fall-through warnings for Clang")
Signed-off-by: Jakub Boehm <boehm.jakub@gmail.com>
Reviewed-by: Simon Horman <horms@kernel.org>
Message-ID: <20241015-net-plip-tx-fix-v1-1-32d8be1c7e0b@gmail.com>
Signed-off-by: Andrew Lunn <andrew@lunn.ch>

authored by

Jakub Boehm and committed by
Andrew Lunn
f99cf996 e4dd8bfe

+1 -1
+1 -1
drivers/net/plip/plip.c
··· 815 815 return HS_TIMEOUT; 816 816 } 817 817 } 818 - break; 818 + fallthrough; 819 819 820 820 case PLIP_PK_LENGTH_LSB: 821 821 if (plip_send(nibble_timeout, dev,