ipmi: ipmi_si_platform: Convert to platform remove callback returning void

The .remove() callback for a platform driver returns an int which makes
many driver authors wrongly assume it's possible to do error handling by
returning an error code. However the value returned is ignored (apart
from emitting a warning) and this typically results in resource leaks.

To improve here there is a quest to make the remove callback return
void. In the first step of this quest all drivers are converted to
.remove_new(), which already returns void. Eventually after all drivers
are converted, .remove_new() will be renamed to .remove().

Trivially convert this driver from always returning zero in the remove
callback to the void returning variant.

Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Message-Id: <789cd7876780241430dd5604bc4322453fe4e581.1709655755.git.u.kleine-koenig@pengutronix.de>
Signed-off-by: Corey Minyard <minyard@acm.org>

authored by Uwe Kleine-König and committed by Corey Minyard f99a9965 26edd74f

+2 -4
+2 -4
drivers/char/ipmi/ipmi_si_platform.c
··· 405 return platform_ipmi_probe(pdev); 406 } 407 408 - static int ipmi_remove(struct platform_device *pdev) 409 { 410 ipmi_si_remove_by_dev(&pdev->dev); 411 - 412 - return 0; 413 } 414 415 static int pdev_match_name(struct device *dev, const void *data) ··· 445 .acpi_match_table = ACPI_PTR(acpi_ipmi_match), 446 }, 447 .probe = ipmi_probe, 448 - .remove = ipmi_remove, 449 .id_table = si_plat_ids 450 }; 451
··· 405 return platform_ipmi_probe(pdev); 406 } 407 408 + static void ipmi_remove(struct platform_device *pdev) 409 { 410 ipmi_si_remove_by_dev(&pdev->dev); 411 } 412 413 static int pdev_match_name(struct device *dev, const void *data) ··· 447 .acpi_match_table = ACPI_PTR(acpi_ipmi_match), 448 }, 449 .probe = ipmi_probe, 450 + .remove_new = ipmi_remove, 451 .id_table = si_plat_ids 452 }; 453