Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

media: v4l2-subdev: Print early in v4l2_subdev_{enable,disable}_streams()

Print debug messages early in v4l2_subdev_enable_streams() and
v4l2_subdev_disable_streams(), before sanity checks take place. This can
help figuring out why something goes wrong, in driver development or
otherwise.

Also print the name of the sub-device where streaming is to be enabled or
disabled.

Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com>
Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Signed-off-by: Hans Verkuil <hverkuil@xs4all.nl>

authored by

Sakari Ailus and committed by
Hans Verkuil
f9869166 7a8212f3

+6 -4
+6 -4
drivers/media/v4l2-core/v4l2-subdev.c
··· 2285 2285 bool use_s_stream; 2286 2286 int ret; 2287 2287 2288 + dev_dbg(dev, "enable streams \"%s\":%u/%#llx\n", sd->entity.name, pad, 2289 + streams_mask); 2290 + 2288 2291 /* A few basic sanity checks first. */ 2289 2292 if (pad >= sd->entity.num_pads) 2290 2293 return -EINVAL; ··· 2334 2331 ret = -EALREADY; 2335 2332 goto done; 2336 2333 } 2337 - 2338 - dev_dbg(dev, "enable streams %u:%#llx\n", pad, streams_mask); 2339 2334 2340 2335 already_streaming = v4l2_subdev_is_streaming(sd); 2341 2336 ··· 2386 2385 bool use_s_stream; 2387 2386 int ret; 2388 2387 2388 + dev_dbg(dev, "disable streams \"%s\":%u/%#llx\n", sd->entity.name, pad, 2389 + streams_mask); 2390 + 2389 2391 /* A few basic sanity checks first. */ 2390 2392 if (pad >= sd->entity.num_pads) 2391 2393 return -EINVAL; ··· 2435 2431 ret = -EALREADY; 2436 2432 goto done; 2437 2433 } 2438 - 2439 - dev_dbg(dev, "disable streams %u:%#llx\n", pad, streams_mask); 2440 2434 2441 2435 if (!use_s_stream) { 2442 2436 /* Call the .disable_streams() operation. */