Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

udf: convert to new timestamp accessors

Convert to using the new inode timestamp accessor functions.

Signed-off-by: Jeff Layton <jlayton@kernel.org>
Link: https://lore.kernel.org/r/20231004185347.80880-72-jlayton@kernel.org
Signed-off-by: Christian Brauner <brauner@kernel.org>

authored by

Jeff Layton and committed by
Christian Brauner
f972fed7 e4cfef33

+32 -26
+2 -2
fs/udf/ialloc.c
··· 100 100 iinfo->i_alloc_type = ICBTAG_FLAG_AD_SHORT; 101 101 else 102 102 iinfo->i_alloc_type = ICBTAG_FLAG_AD_LONG; 103 - inode->i_mtime = inode->i_atime = inode_set_ctime_current(inode); 104 - iinfo->i_crtime = inode->i_mtime; 103 + simple_inode_init_ts(inode); 104 + iinfo->i_crtime = inode_get_mtime(inode); 105 105 if (unlikely(insert_inode_locked(inode) < 0)) { 106 106 make_bad_inode(inode); 107 107 iput(inode);
+22 -16
fs/udf/inode.c
··· 1296 1296 goto out_unlock; 1297 1297 } 1298 1298 update_time: 1299 - inode->i_mtime = inode_set_ctime_current(inode); 1299 + inode_set_mtime_to_ts(inode, inode_set_ctime_current(inode)); 1300 1300 if (IS_SYNC(inode)) 1301 1301 udf_sync_inode(inode); 1302 1302 else ··· 1327 1327 int bs = inode->i_sb->s_blocksize; 1328 1328 int ret = -EIO; 1329 1329 uint32_t uid, gid; 1330 - struct timespec64 ctime; 1330 + struct timespec64 ts; 1331 1331 1332 1332 reread: 1333 1333 if (iloc->partitionReferenceNum >= sbi->s_partitions) { ··· 1504 1504 inode->i_blocks = le64_to_cpu(fe->logicalBlocksRecorded) << 1505 1505 (inode->i_sb->s_blocksize_bits - 9); 1506 1506 1507 - udf_disk_stamp_to_time(&inode->i_atime, fe->accessTime); 1508 - udf_disk_stamp_to_time(&inode->i_mtime, fe->modificationTime); 1509 - udf_disk_stamp_to_time(&ctime, fe->attrTime); 1510 - inode_set_ctime_to_ts(inode, ctime); 1507 + udf_disk_stamp_to_time(&ts, fe->accessTime); 1508 + inode_set_atime_to_ts(inode, ts); 1509 + udf_disk_stamp_to_time(&ts, fe->modificationTime); 1510 + inode_set_mtime_to_ts(inode, ts); 1511 + udf_disk_stamp_to_time(&ts, fe->attrTime); 1512 + inode_set_ctime_to_ts(inode, ts); 1511 1513 1512 1514 iinfo->i_unique = le64_to_cpu(fe->uniqueID); 1513 1515 iinfo->i_lenEAttr = le32_to_cpu(fe->lengthExtendedAttr); ··· 1521 1519 inode->i_blocks = le64_to_cpu(efe->logicalBlocksRecorded) << 1522 1520 (inode->i_sb->s_blocksize_bits - 9); 1523 1521 1524 - udf_disk_stamp_to_time(&inode->i_atime, efe->accessTime); 1525 - udf_disk_stamp_to_time(&inode->i_mtime, efe->modificationTime); 1522 + udf_disk_stamp_to_time(&ts, efe->accessTime); 1523 + inode_set_atime_to_ts(inode, ts); 1524 + udf_disk_stamp_to_time(&ts, efe->modificationTime); 1525 + inode_set_mtime_to_ts(inode, ts); 1526 + udf_disk_stamp_to_time(&ts, efe->attrTime); 1527 + inode_set_ctime_to_ts(inode, ts); 1526 1528 udf_disk_stamp_to_time(&iinfo->i_crtime, efe->createTime); 1527 - udf_disk_stamp_to_time(&ctime, efe->attrTime); 1528 - inode_set_ctime_to_ts(inode, ctime); 1529 1529 1530 1530 iinfo->i_unique = le64_to_cpu(efe->uniqueID); 1531 1531 iinfo->i_lenEAttr = le32_to_cpu(efe->lengthExtendedAttr); ··· 1802 1798 inode->i_sb->s_blocksize - sizeof(struct fileEntry)); 1803 1799 fe->logicalBlocksRecorded = cpu_to_le64(lb_recorded); 1804 1800 1805 - udf_time_to_disk_stamp(&fe->accessTime, inode->i_atime); 1806 - udf_time_to_disk_stamp(&fe->modificationTime, inode->i_mtime); 1801 + udf_time_to_disk_stamp(&fe->accessTime, inode_get_atime(inode)); 1802 + udf_time_to_disk_stamp(&fe->modificationTime, inode_get_mtime(inode)); 1807 1803 udf_time_to_disk_stamp(&fe->attrTime, inode_get_ctime(inode)); 1808 1804 memset(&(fe->impIdent), 0, sizeof(struct regid)); 1809 1805 strcpy(fe->impIdent.ident, UDF_ID_DEVELOPER); ··· 1833 1829 cpu_to_le32(inode->i_sb->s_blocksize); 1834 1830 } 1835 1831 1836 - udf_adjust_time(iinfo, inode->i_atime); 1837 - udf_adjust_time(iinfo, inode->i_mtime); 1832 + udf_adjust_time(iinfo, inode_get_atime(inode)); 1833 + udf_adjust_time(iinfo, inode_get_mtime(inode)); 1838 1834 udf_adjust_time(iinfo, inode_get_ctime(inode)); 1839 1835 1840 - udf_time_to_disk_stamp(&efe->accessTime, inode->i_atime); 1841 - udf_time_to_disk_stamp(&efe->modificationTime, inode->i_mtime); 1836 + udf_time_to_disk_stamp(&efe->accessTime, 1837 + inode_get_atime(inode)); 1838 + udf_time_to_disk_stamp(&efe->modificationTime, 1839 + inode_get_mtime(inode)); 1842 1840 udf_time_to_disk_stamp(&efe->createTime, iinfo->i_crtime); 1843 1841 udf_time_to_disk_stamp(&efe->attrTime, inode_get_ctime(inode)); 1844 1842
+8 -8
fs/udf/namei.c
··· 365 365 *(__le32 *)((struct allocDescImpUse *)iter.fi.icb.impUse)->impUse = 366 366 cpu_to_le32(iinfo->i_unique & 0x00000000FFFFFFFFUL); 367 367 udf_fiiter_write_fi(&iter, NULL); 368 - dir->i_mtime = inode_set_ctime_current(dir); 368 + inode_set_mtime_to_ts(dir, inode_set_ctime_current(dir)); 369 369 mark_inode_dirty(dir); 370 370 udf_fiiter_release(&iter); 371 371 udf_add_fid_counter(dir->i_sb, false, 1); ··· 471 471 udf_fiiter_release(&iter); 472 472 udf_add_fid_counter(dir->i_sb, true, 1); 473 473 inc_nlink(dir); 474 - dir->i_mtime = inode_set_ctime_current(dir); 474 + inode_set_mtime_to_ts(dir, inode_set_ctime_current(dir)); 475 475 mark_inode_dirty(dir); 476 476 d_instantiate_new(dentry, inode); 477 477 ··· 523 523 inode->i_size = 0; 524 524 inode_dec_link_count(dir); 525 525 udf_add_fid_counter(dir->i_sb, true, -1); 526 - dir->i_mtime = inode_set_ctime_to_ts(dir, 527 - inode_set_ctime_current(inode)); 526 + inode_set_mtime_to_ts(dir, 527 + inode_set_ctime_to_ts(dir, inode_set_ctime_current(inode))); 528 528 mark_inode_dirty(dir); 529 529 ret = 0; 530 530 end_rmdir: ··· 555 555 set_nlink(inode, 1); 556 556 } 557 557 udf_fiiter_delete_entry(&iter); 558 - dir->i_mtime = inode_set_ctime_current(dir); 558 + inode_set_mtime_to_ts(dir, inode_set_ctime_current(dir)); 559 559 mark_inode_dirty(dir); 560 560 inode_dec_link_count(inode); 561 561 udf_add_fid_counter(dir->i_sb, false, -1); ··· 748 748 udf_add_fid_counter(dir->i_sb, false, 1); 749 749 inode_set_ctime_current(inode); 750 750 mark_inode_dirty(inode); 751 - dir->i_mtime = inode_set_ctime_current(dir); 751 + inode_set_mtime_to_ts(dir, inode_set_ctime_current(dir)); 752 752 mark_inode_dirty(dir); 753 753 ihold(inode); 754 754 d_instantiate(dentry, inode); ··· 866 866 udf_add_fid_counter(old_dir->i_sb, S_ISDIR(new_inode->i_mode), 867 867 -1); 868 868 } 869 - old_dir->i_mtime = inode_set_ctime_current(old_dir); 870 - new_dir->i_mtime = inode_set_ctime_current(new_dir); 869 + inode_set_mtime_to_ts(old_dir, inode_set_ctime_current(old_dir)); 870 + inode_set_mtime_to_ts(new_dir, inode_set_ctime_current(new_dir)); 871 871 mark_inode_dirty(old_dir); 872 872 mark_inode_dirty(new_dir); 873 873