Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

net: enetc: shorten enetc_setup_xdp_prog() error message to fit NETLINK_MAX_FMTMSG_LEN

NETLINK_MAX_FMTMSG_LEN is currently hardcoded to 80, and we provide an
error printf-formatted string having 96 characters including the
terminating \0. Assuming each %d (representing a queue) gets replaced by
a number having at most 2 digits (a reasonable assumption), the final
string is also 96 characters wide, which is too much.

Reduce the verbiage a bit by removing some (partially) redundant words,
which makes the new printf-formatted string be 73 characters wide with
the trailing newline.

Fixes: 800db2d125c2 ("net: enetc: ensure we always have a minimum number of TXQs for stack")
Reported-by: kernel test robot <lkp@intel.com>
Closes: https://lore.kernel.org/lkml/202311061336.4dsWMT1h-lkp@intel.com/
Signed-off-by: Vladimir Oltean <vladimir.oltean@nxp.com>
Link: https://lore.kernel.org/r/20231106160311.616118-1-vladimir.oltean@nxp.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>

authored by

Vladimir Oltean and committed by
Jakub Kicinski
f968c564 34c4effa

+1 -1
+1 -1
drivers/net/ethernet/freescale/enetc/enetc.c
··· 2769 2769 if (priv->min_num_stack_tx_queues + num_xdp_tx_queues > 2770 2770 priv->num_tx_rings) { 2771 2771 NL_SET_ERR_MSG_FMT_MOD(extack, 2772 - "Reserving %d XDP TXQs does not leave a minimum of %d TXQs for network stack (total %d available)", 2772 + "Reserving %d XDP TXQs does not leave a minimum of %d for stack (total %d)", 2773 2773 num_xdp_tx_queues, 2774 2774 priv->min_num_stack_tx_queues, 2775 2775 priv->num_tx_rings);