Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

x86/asm: Add MONITORX/MWAITX instruction support

AMD Carrizo processors (Family 15h, Models 60h-6fh) added a new
feature called MWAITX (MWAIT with extensions) as an extension to
MONITOR/MWAIT.

This new instruction controls a configurable timer which causes
the core to exit wait state on timer expiration, in addition to
"normal" MWAIT condition of reading from a monitored VA.

Compared to MONITOR/MWAIT, there are minor differences in opcode
and input parameters:

MWAITX ECX[1]: enable timer if set
MWAITX EBX[31:0]: max wait time expressed in SW P0 clocks ==
TSC. The software P0 frequency is the same as the TSC frequency.

MWAIT MWAITX
opcode 0f 01 c9 | 0f 01 fb
ECX[0] value of RFLAGS.IF seen by instruction
ECX[1] unused/#GP if set | enable timer if set
ECX[31:2] unused/#GP if set
EAX unused (reserve for hint)
EBX[31:0] unused | max wait time (SW P0 == TSC)

MONITOR MONITORX
opcode 0f 01 c8 | 0f 01 fa
EAX (logical) address to monitor
ECX #GP if not zero

Max timeout = EBX/(TSC frequency)

Signed-off-by: Huang Rui <ray.huang@amd.com>
Signed-off-by: Borislav Petkov <bp@suse.de>
Cc: Aaron Lu <aaron.lu@intel.com>
Cc: Alexander Shishkin <alexander.shishkin@linux.intel.com>
Cc: Andreas Herrmann <herrmann.der.user@gmail.com>
Cc: Andy Lutomirski <luto@amacapital.net>
Cc: Dave Hansen <dave.hansen@linux.intel.com>
Cc: Dirk Brandewie <dirk.j.brandewie@intel.com>
Cc: Fengguang Wu <fengguang.wu@intel.com>
Cc: Frédéric Weisbecker <fweisbec@gmail.com>
Cc: H. Peter Anvin <hpa@zytor.com>
Cc: John Stultz <john.stultz@linaro.org>
Cc: Josh Triplett <josh@joshtriplett.org>
Cc: Len Brown <lenb@kernel.org>
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Mike Galbraith <bitbucket@online.de>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Rafael J. Wysocki <rjw@rjwysocki.net>
Cc: Ross Zwisler <ross.zwisler@linux.intel.com>
Cc: Thomas Gleixner <tglx@linutronix.de>
Cc: Tony Li <tony.li@amd.com>
Link: http://lkml.kernel.org/r/1439201994-28067-3-git-send-email-bp@alien8.de
Signed-off-by: Ingo Molnar <mingo@kernel.org>

authored by

Huang Rui and committed by
Ingo Molnar
f9675674 f0a97af8

+46
+1
arch/x86/include/asm/cpufeature.h
··· 176 176 #define X86_FEATURE_PERFCTR_NB ( 6*32+24) /* NB performance counter extensions */ 177 177 #define X86_FEATURE_BPEXT (6*32+26) /* data breakpoint extension */ 178 178 #define X86_FEATURE_PERFCTR_L2 ( 6*32+28) /* L2 performance counter extensions */ 179 + #define X86_FEATURE_MWAITX ( 6*32+29) /* MWAIT extension (MONITORX/MWAITX) */ 179 180 180 181 /* 181 182 * Auxiliary flags: Linux defined - For features scattered in various
+45
arch/x86/include/asm/mwait.h
··· 14 14 #define CPUID5_ECX_INTERRUPT_BREAK 0x2 15 15 16 16 #define MWAIT_ECX_INTERRUPT_BREAK 0x1 17 + #define MWAITX_ECX_TIMER_ENABLE BIT(1) 18 + #define MWAITX_MAX_LOOPS ((u32)-1) 19 + #define MWAITX_DISABLE_CSTATES 0xf 17 20 18 21 static inline void __monitor(const void *eax, unsigned long ecx, 19 22 unsigned long edx) ··· 26 23 :: "a" (eax), "c" (ecx), "d"(edx)); 27 24 } 28 25 26 + static inline void __monitorx(const void *eax, unsigned long ecx, 27 + unsigned long edx) 28 + { 29 + /* "monitorx %eax, %ecx, %edx;" */ 30 + asm volatile(".byte 0x0f, 0x01, 0xfa;" 31 + :: "a" (eax), "c" (ecx), "d"(edx)); 32 + } 33 + 29 34 static inline void __mwait(unsigned long eax, unsigned long ecx) 30 35 { 31 36 /* "mwait %eax, %ecx;" */ 32 37 asm volatile(".byte 0x0f, 0x01, 0xc9;" 33 38 :: "a" (eax), "c" (ecx)); 39 + } 40 + 41 + /* 42 + * MWAITX allows for a timer expiration to get the core out a wait state in 43 + * addition to the default MWAIT exit condition of a store appearing at a 44 + * monitored virtual address. 45 + * 46 + * Registers: 47 + * 48 + * MWAITX ECX[1]: enable timer if set 49 + * MWAITX EBX[31:0]: max wait time expressed in SW P0 clocks. The software P0 50 + * frequency is the same as the TSC frequency. 51 + * 52 + * Below is a comparison between MWAIT and MWAITX on AMD processors: 53 + * 54 + * MWAIT MWAITX 55 + * opcode 0f 01 c9 | 0f 01 fb 56 + * ECX[0] value of RFLAGS.IF seen by instruction 57 + * ECX[1] unused/#GP if set | enable timer if set 58 + * ECX[31:2] unused/#GP if set 59 + * EAX unused (reserve for hint) 60 + * EBX[31:0] unused | max wait time (P0 clocks) 61 + * 62 + * MONITOR MONITORX 63 + * opcode 0f 01 c8 | 0f 01 fa 64 + * EAX (logical) address to monitor 65 + * ECX #GP if not zero 66 + */ 67 + static inline void __mwaitx(unsigned long eax, unsigned long ebx, 68 + unsigned long ecx) 69 + { 70 + /* "mwaitx %eax, %ebx, %ecx;" */ 71 + asm volatile(".byte 0x0f, 0x01, 0xfb;" 72 + :: "a" (eax), "b" (ebx), "c" (ecx)); 34 73 } 35 74 36 75 static inline void __sti_mwait(unsigned long eax, unsigned long ecx)