Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

net: octeon_ep_vf: fix free_irq dev_id mismatch in IRQ rollback

octep_vf_request_irqs() requests MSI-X queue IRQs with dev_id set to
ioq_vector. If request_irq() fails part-way, the rollback loop calls
free_irq() with dev_id set to 'oct', which does not match the original
dev_id and may leave the irqaction registered.

This can keep IRQ handlers alive while ioq_vector is later freed during
unwind/teardown, leading to a use-after-free or crash when an interrupt
fires.

Fix the error path to free IRQs with the same ioq_vector dev_id used
during request_irq().

Fixes: 1cd3b407977c ("octeon_ep_vf: add Tx/Rx processing and interrupt support")
Signed-off-by: Kery Qi <qikeyu2017@gmail.com>
Link: https://patch.msgid.link/20260108164256.1749-2-qikeyu2017@gmail.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>

authored by

Kery Qi and committed by
Jakub Kicinski
f93fc5d1 16ce6e6f

+1 -1
+1 -1
drivers/net/ethernet/marvell/octeon_ep_vf/octep_vf_main.c
··· 218 218 ioq_irq_err: 219 219 while (i) { 220 220 --i; 221 - free_irq(oct->msix_entries[i].vector, oct); 221 + free_irq(oct->msix_entries[i].vector, oct->ioq_vector[i]); 222 222 } 223 223 return -1; 224 224 }