Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

scsi: sd: Fix interpretation of VPD B9h length

Fixing the interpretation of the length of the B9h VPD page (Concurrent
Positioning Ranges). Adding 4 is necessary as the first 4 bytes of the page
is the header with page number and length information. Adding 3 was likely
a misinterpretation of the SBC-5 specification which sets all offsets
starting at zero.

This fixes the error in dmesg:

[ 9.014456] sd 1:0:0:0: [sda] Invalid Concurrent Positioning Ranges VPD page

Link: https://lore.kernel.org/r/20220602225113.10218-4-tyler.erickson@seagate.com
Fixes: e815d36548f0 ("scsi: sd: add concurrent positioning ranges support")
Cc: stable@vger.kernel.org
Tested-by: Michael English <michael.english@seagate.com>
Reviewed-by: Muhammad Ahmad <muhammad.ahmad@seagate.com>
Reviewed-by: Damien Le Moal <damien.lemoal@opensource.wdc.com>
Reviewed-by: Hannes Reinecke <hare@suse.de>
Signed-off-by: Tyler Erickson <tyler.erickson@seagate.com>
Signed-off-by: Christoph Hellwig <hch@lst.de>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>

authored by

Tyler Erickson and committed by
Martin K. Petersen
f92de9d1 f2906aa8

+1 -1
+1 -1
drivers/scsi/sd.c
··· 3072 3072 goto out; 3073 3073 3074 3074 /* We must have at least a 64B header and one 32B range descriptor */ 3075 - vpd_len = get_unaligned_be16(&buffer[2]) + 3; 3075 + vpd_len = get_unaligned_be16(&buffer[2]) + 4; 3076 3076 if (vpd_len > buf_len || vpd_len < 64 + 32 || (vpd_len & 31)) { 3077 3077 sd_printk(KERN_ERR, sdkp, 3078 3078 "Invalid Concurrent Positioning Ranges VPD page\n");