Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

clk: bcm: bcm53573: fix OF node leak in init

Driver code is leaking OF node reference from of_get_parent() in
bcm53573_ilp_init(). Usage of of_get_parent() is not needed in the
first place, because the parent node will not be freed while we are
processing given node (triggered by CLK_OF_DECLARE()). Thus fix the
leak by accessing parent directly, instead of of_get_parent().

Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Link: https://lore.kernel.org/r/20240826065801.17081-1-krzysztof.kozlowski@linaro.org
Signed-off-by: Stephen Boyd <sboyd@kernel.org>

authored by

Krzysztof Kozlowski and committed by
Stephen Boyd
f92d67e2 f7e41b65

+1 -1
+1 -1
drivers/clk/bcm/clk-bcm53573-ilp.c
··· 112 112 goto err_free_ilp; 113 113 } 114 114 115 - ilp->regmap = syscon_node_to_regmap(of_get_parent(np)); 115 + ilp->regmap = syscon_node_to_regmap(np->parent); 116 116 if (IS_ERR(ilp->regmap)) { 117 117 err = PTR_ERR(ilp->regmap); 118 118 goto err_free_ilp;