Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

drm/nouveau/tegra: Fix error pointer vs NULL return in nvkm_device_tegra_resource_addr()

The nvkm_device_tegra_resource() function returns a mix of error pointers
and NULL. The callers only expect it to return NULL on error. Change it
to only return NULL.

Fixes: 76b8f81a5b92 ("drm/nouveau: improve handling of 64-bit BARs")
Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
Reviewed-by: Timur Tabi <ttabi@nvidia.com>
Signed-off-by: Dave Airlie <airlied@redhat.com>
Link: https://lore.kernel.org/dri-devel/334404bdf60765cb5a8e855a74c688bc537531ee.camel@nvidia.com/T/#t

authored by

Dan Carpenter and committed by
Dave Airlie
f8bb3ed3 002619c8

+1 -1
+1 -1
drivers/gpu/drm/nouveau/nvkm/engine/device/tegra.c
··· 196 196 case NVKM_BAR1_FB : idx = 1; break; 197 197 default: 198 198 WARN_ON(1); 199 - return ERR_PTR(-EINVAL); 199 + return NULL; 200 200 } 201 201 202 202 return platform_get_resource(tdev->pdev, IORESOURCE_MEM, idx);