mac80211: allow interface settings changes only when down

Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git

kernel os linux

We currently allow monitor flags changes and mesh ID changes when
the interface is up, which can lead to trouble. Change it to only
allow when down.

Signed-off-by: Johannes Berg <johannes@sipsolutions.net>
Signed-off-by: John W. Linville <linville@tuxdriver.com>

authored by

Johannes Berg and committed by

John W. Linville 17 years ago f8b25cda 723b038d

1 changed file

expand all

net

mac80211

cfg.c

net/mac80211/cfg.c

··· 100 100 if (ret) 101 101 return ret; 102 102 103 + if (netif_running(sdata->dev)) 104 + return -EBUSY; 105 + 103 106 if (ieee80211_vif_is_mesh(&sdata->vif) && params->mesh_id_len) 104 107 ieee80211_sdata_set_mesh_id(sdata, 105 108 params->mesh_id_len,