Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

openvswitch: Remove conntrack Kconfig option.

There's no particular desire to have conntrack action support in Open
vSwitch as an independently configurable bit, rather just to ensure
there is not a hard dependency. This exposed option doesn't accurately
reflect the conntrack dependency when enabled, so simplify this by
removing the option. Compile the support if NF_CONNTRACK is enabled.

Fixes: 7f8a436eaa2c ("openvswitch: Add conntrack action")
Signed-off-by: Joe Stringer <joestringer@nicira.com>
Acked-by: Pravin B Shelar <pshelar@nicira.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

authored by

Joe Stringer and committed by
David S. Miller
f88f69dd 585e7e1a

+6 -14
+1 -11
net/openvswitch/Kconfig
··· 5 5 config OPENVSWITCH 6 6 tristate "Open vSwitch" 7 7 depends on INET 8 + depends on (!NF_CONNTRACK || NF_CONNTRACK) 8 9 select LIBCRC32C 9 10 select MPLS 10 11 select NET_MPLS_GSO ··· 31 30 called openvswitch. 32 31 33 32 If unsure, say N. 34 - 35 - config OPENVSWITCH_CONNTRACK 36 - bool "Open vSwitch conntrack action support" 37 - depends on OPENVSWITCH 38 - depends on NF_CONNTRACK 39 - default OPENVSWITCH 40 - ---help--- 41 - If you say Y here, then Open vSwitch module will be able to pass 42 - packets through conntrack. 43 - 44 - Say N to exclude this support and reduce the binary size. 45 33 46 34 config OPENVSWITCH_GRE 47 35 tristate "Open vSwitch GRE tunneling support"
+3 -1
net/openvswitch/Makefile
··· 15 15 vport-internal_dev.o \ 16 16 vport-netdev.o 17 17 18 - openvswitch-$(CONFIG_OPENVSWITCH_CONNTRACK) += conntrack.o 18 + ifneq ($(CONFIG_NF_CONNTRACK),) 19 + openvswitch-y += conntrack.o 20 + endif 19 21 20 22 obj-$(CONFIG_OPENVSWITCH_VXLAN)+= vport-vxlan.o 21 23 obj-$(CONFIG_OPENVSWITCH_GENEVE)+= vport-geneve.o
+2 -2
net/openvswitch/conntrack.h
··· 19 19 struct ovs_conntrack_info; 20 20 enum ovs_key_attr; 21 21 22 - #if defined(CONFIG_OPENVSWITCH_CONNTRACK) 22 + #if IS_ENABLED(CONFIG_NF_CONNTRACK) 23 23 void ovs_ct_init(struct net *); 24 24 void ovs_ct_exit(struct net *); 25 25 bool ovs_ct_verify(struct net *, enum ovs_key_attr attr); ··· 82 82 } 83 83 84 84 static inline void ovs_ct_free_action(const struct nlattr *a) { } 85 - #endif 85 + #endif /* CONFIG_NF_CONNTRACK */ 86 86 #endif /* ovs_conntrack.h */