Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

Input: lpc32xx-keys - remove an unused field in struct lpc32xx_kscan_drv

In "struct lpc32xx_kscan_drv", the 'irq' field is unused.
Remove it.

Found with cppcheck, unusedStructMember.

While at it, move the 'row_shift' field in order to fill a hole in the
structure (at least on 64 bits arch).

Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Link: https://lore.kernel.org/r/e006dfb77e35762c6e4f8ba6ba792b0c52fde375.1714545542.git.christophe.jaillet@wanadoo.fr
Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>

authored by

Christophe JAILLET and committed by
Dmitry Torokhov
f88f4a16 9df32785

+1 -2
+1 -2
drivers/input/keyboard/lpc32xx-keys.c
··· 57 57 struct input_dev *input; 58 58 struct clk *clk; 59 59 void __iomem *kscan_base; 60 - unsigned int irq; 61 60 62 61 u32 matrix_sz; /* Size of matrix in XxY, ie. 3 = 3x3 */ 63 62 u32 deb_clks; /* Debounce clocks (based on 32KHz clock) */ 64 63 u32 scan_delay; /* Scan delay (based on 32KHz clock) */ 65 64 66 - unsigned short *keymap; /* Pointer to key map for the scan matrix */ 67 65 unsigned int row_shift; 66 + unsigned short *keymap; /* Pointer to key map for the scan matrix */ 68 67 69 68 u8 lastkeystates[8]; 70 69 };