Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

backlight: 88pm860x_bl: Add missing of_node_put

for_each_child_of_node performs an of_node_get on each iteration, so
a break out of the loop requires an of_node_put.

The semantic patch that fixes this problem is as follows
(http://coccinelle.lip6.fr):

// <smpl>
@@
expression root,e;
local idexpression child;
iterator name for_each_child_of_node;
@@

for_each_child_of_node(root, child) {
... when != of_node_put(child)
when != e = child
+ of_node_put(child);
? break;
...
}
... when != child
// </smpl>

Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
Signed-off-by: Lee Jones <lee.jones@linaro.org>

authored by

Julia Lawall and committed by
Lee Jones
f85de2d9 7111c6c6

+1
+1
drivers/video/backlight/88pm860x_bl.c
··· 180 180 data->iset = PM8606_WLED_CURRENT(iset); 181 181 of_property_read_u32(np, "marvell,88pm860x-pwm", 182 182 &data->pwm); 183 + of_node_put(np); 183 184 break; 184 185 } 185 186 }