Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

pwm: samsung: Simplify using dev_err_probe()

dev_err_probe() simplifies and improves the idiom "emit error message +
return error code". Apply it accordingly.

Link: https://lore.kernel.org/r/27a55fc05eb13802c9eddc600d0460e279388999.1707900770.git.u.kleine-koenig@pengutronix.de
Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>

+8 -12
+8 -12
drivers/pwm/pwm-samsung.c
··· 564 564 if (ret) 565 565 return ret; 566 566 } else { 567 - if (!pdev->dev.platform_data) { 568 - dev_err(&pdev->dev, "no platform data specified\n"); 569 - return -EINVAL; 570 - } 567 + if (!pdev->dev.platform_data) 568 + return dev_err_probe(&pdev->dev, -EINVAL, 569 + "no platform data specified\n"); 571 570 572 571 memcpy(&our_chip->variant, pdev->dev.platform_data, 573 572 sizeof(our_chip->variant)); ··· 577 578 return PTR_ERR(our_chip->base); 578 579 579 580 our_chip->base_clk = devm_clk_get_enabled(&pdev->dev, "timers"); 580 - if (IS_ERR(our_chip->base_clk)) { 581 - dev_err(dev, "failed to get timer base clk\n"); 582 - return PTR_ERR(our_chip->base_clk); 583 - } 581 + if (IS_ERR(our_chip->base_clk)) 582 + return dev_err_probe(dev, PTR_ERR(our_chip->base_clk), 583 + "failed to get timer base clk\n"); 584 584 585 585 for (chan = 0; chan < SAMSUNG_PWM_NUM; ++chan) 586 586 if (our_chip->variant.output_mask & BIT(chan)) ··· 592 594 platform_set_drvdata(pdev, chip); 593 595 594 596 ret = devm_pwmchip_add(&pdev->dev, chip); 595 - if (ret < 0) { 596 - dev_err(dev, "failed to register PWM chip\n"); 597 - return ret; 598 - } 597 + if (ret < 0) 598 + return dev_err_probe(dev, ret, "failed to register PWM chip\n"); 599 599 600 600 dev_dbg(dev, "base_clk at %lu, tclk0 at %lu, tclk1 at %lu\n", 601 601 clk_get_rate(our_chip->base_clk),