Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

backlight: 88pm860x_bl: use devm_backlight_device_register()

Use devm_backlight_device_register() to make cleanup paths simpler, and
remove unnecessary remove().

Signed-off-by: Jingoo Han <jg1.han@samsung.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>

authored by

Jingoo Han and committed by
Linus Torvalds
f829c9ef c512794c

+2 -14
+2 -14
drivers/video/backlight/88pm860x_bl.c
··· 243 243 memset(&props, 0, sizeof(struct backlight_properties)); 244 244 props.type = BACKLIGHT_RAW; 245 245 props.max_brightness = MAX_BRIGHTNESS; 246 - bl = backlight_device_register(name, &pdev->dev, data, 246 + bl = devm_backlight_device_register(&pdev->dev, name, &pdev->dev, data, 247 247 &pm860x_backlight_ops, &props); 248 248 if (IS_ERR(bl)) { 249 249 dev_err(&pdev->dev, "failed to register backlight\n"); ··· 256 256 /* read current backlight */ 257 257 ret = pm860x_backlight_get_brightness(bl); 258 258 if (ret < 0) 259 - goto out_brt; 259 + return ret; 260 260 261 261 backlight_update_status(bl); 262 - return 0; 263 - out_brt: 264 - backlight_device_unregister(bl); 265 - return ret; 266 - } 267 - 268 - static int pm860x_backlight_remove(struct platform_device *pdev) 269 - { 270 - struct backlight_device *bl = platform_get_drvdata(pdev); 271 - 272 - backlight_device_unregister(bl); 273 262 return 0; 274 263 } 275 264 ··· 268 279 .owner = THIS_MODULE, 269 280 }, 270 281 .probe = pm860x_backlight_probe, 271 - .remove = pm860x_backlight_remove, 272 282 }; 273 283 274 284 module_platform_driver(pm860x_backlight_driver);