tjh.dev / kernel
Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux
fork atom

spi: spi-qpic-snand: don't hardcode ECC steps

NAND devices with different page sizes requires different number
of ECC steps, yet the qcom_spi_ecc_init_ctx_pipelined() function
sets 4 steps in 'ecc_cfg' unconditionally.

The correct number of the steps is calculated earlier in the
function already, so use that instead of the hardcoded value.

Fixes: 7304d1909080 ("spi: spi-qpic: add driver for QCOM SPI NAND flash Interface")
Signed-off-by: Gabor Juhos <j4g8y7@gmail.com>
Link: https://patch.msgid.link/20250723-qpic-snand-fix-steps-v1-1-d800695dde4c@gmail.com
Signed-off-by: Mark Brown <broonie@kernel.org>

authored by Gabor Juhos and committed by Mark Brown f8200348 71050521

options
unified split
Changed files
+1 -1
drivers
spi
spi-qpic-snand.c
+1 -1
drivers/spi/spi-qpic-snand.c
··· 308 308 ecc_cfg->bch_enabled = true; 309 309 ecc_cfg->bytes = ecc_cfg->ecc_bytes_hw + ecc_cfg->spare_bytes + ecc_cfg->bbm_size; 310 310 311 - ecc_cfg->steps = 4; 311 + ecc_cfg->steps = cwperpage; 312 312 ecc_cfg->cw_data = 516; 313 313 ecc_cfg->cw_size = ecc_cfg->cw_data + ecc_cfg->bytes; 314 314 bad_block_byte = mtd->writesize - ecc_cfg->cw_size * (cwperpage - 1) + 1;