Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

soc: ti: knav_qmss_queue: Fix linking RAM setup for queue managers

Configure linking RAM for both queue managers also in case
when only linking RAM 0 is specified in device tree.

Currently hwqueue driver configures linking RAM(s) to be used
cooperatively by the QMs (shared mode). Therefore if both
queue managers are used then both must be configured with
exactly the same linking RAM info (base address and size)
independent of the number of linking RAM(s) specified in the
device tree.
For proper operation only one linking RAM is required and in most
cases this can be internal one as long as it is able to handle
the number of descriptors used in the system.
Current driver code however skips configuration of second
queue manager if second linking RAM is not specified.
If the configuration for the QM2 is missing there will be
a crash when it tries to push/pop descriptors from its queues.

Signed-off-by: Michal Morawiec <michal.1.morawiec.ext@nokia.com>
Signed-off-by: Santosh Shilimkar <ssantosh@kernel.org>

authored by

Michal Morawiec and committed by
Santosh Shilimkar
f7f2bccd 6af1a073

+1 -1
+1 -1
drivers/soc/ti/knav_qmss_queue.c
··· 1179 1179 1180 1180 block++; 1181 1181 if (!block->size) 1182 - return 0; 1182 + continue; 1183 1183 1184 1184 dev_dbg(kdev->dev, "linkram1: phys:%x, virt:%p, size:%x\n", 1185 1185 block->phys, block->virt, block->size);