Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

[PATCH] __attribute__ placement fixes

The variable attributes "packed" and "align" when used with struct, should
have the following order:

struct ... {...} __attribute__((packed)) var;

This patch fixes few instances where the variable and attributes are placed
the other way around and had no effect.

Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>

authored by

Vinay K Nallamothu and committed by
Linus Torvalds
f78fc874 e49332bd

+5 -5
+2 -2
drivers/net/gt96100eth.h
··· 214 214 u32 cmdstat; 215 215 u32 next; 216 216 u32 buff_ptr; 217 - } gt96100_td_t __attribute__ ((packed)); 217 + } __attribute__ ((packed)) gt96100_td_t; 218 218 219 219 typedef struct { 220 220 #ifdef DESC_BE ··· 227 227 u32 cmdstat; 228 228 u32 next; 229 229 u32 buff_ptr; 230 - } gt96100_rd_t __attribute__ ((packed)); 230 + } __attribute__ ((packed)) gt96100_rd_t; 231 231 232 232 233 233 /* Values for the Tx command-status descriptor entry. */
+1 -1
include/asm-m68knommu/MC68328.h
··· 993 993 volatile unsigned short int pad1; 994 994 volatile unsigned short int pad2; 995 995 volatile unsigned short int pad3; 996 - } m68328_uart __attribute__((packed)); 996 + } __attribute__((packed)) m68328_uart; 997 997 998 998 999 999 /**********
+1 -1
include/asm-m68knommu/MC68EZ328.h
··· 815 815 volatile unsigned short int nipr; 816 816 volatile unsigned short int pad1; 817 817 volatile unsigned short int pad2; 818 - } m68328_uart __attribute__((packed)); 818 + } __attribute__((packed)) m68328_uart; 819 819 820 820 821 821 /**********
+1 -1
include/asm-m68knommu/MC68VZ328.h
··· 909 909 volatile unsigned short int nipr; 910 910 volatile unsigned short int hmark; 911 911 volatile unsigned short int unused; 912 - } m68328_uart __attribute__((packed)); 912 + } __attribute__((packed)) m68328_uart; 913 913 914 914 915 915