Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

ASoC: codecs: cs47l85: Convert to platform remove callback returning void

The .remove() callback for a platform driver returns an int which makes
many driver authors wrongly assume it's possible to do error handling by
returning an error code. However the value returned is (mostly) ignored
and this typically results in resource leaks. To improve here there is a
quest to make the remove callback return void. In the first step of this
quest all drivers are converted to .remove_new() which already returns
void.

Trivially convert this driver from always returning zero in the remove
callback to the void returning variant.

Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Acked-by: Charles Keepax <ckeepax@opensource.cirrus.com>
Acked-by: Takashi Iwai <tiwai@suse.de>
Acked-by: Nicolas Ferre <nicolas.ferre@microchip.com>
Link: https://lore.kernel.org/r/20230315150745.67084-46-u.kleine-koenig@pengutronix.de
Signed-off-by: Mark Brown <broonie@kernel.org>

authored by

Uwe Kleine-König and committed by
Mark Brown
f71d98e5 b9cc4f89

+2 -4
+2 -4
sound/soc/codecs/cs47l85.c
··· 2695 2695 return ret; 2696 2696 } 2697 2697 2698 - static int cs47l85_remove(struct platform_device *pdev) 2698 + static void cs47l85_remove(struct platform_device *pdev) 2699 2699 { 2700 2700 struct cs47l85 *cs47l85 = platform_get_drvdata(pdev); 2701 2701 int i; ··· 2709 2709 madera_free_irq(cs47l85->core.madera, MADERA_IRQ_DSP_IRQ1, cs47l85); 2710 2710 madera_free_overheat(&cs47l85->core); 2711 2711 madera_core_free(&cs47l85->core); 2712 - 2713 - return 0; 2714 2712 } 2715 2713 2716 2714 static struct platform_driver cs47l85_codec_driver = { ··· 2716 2718 .name = "cs47l85-codec", 2717 2719 }, 2718 2720 .probe = &cs47l85_probe, 2719 - .remove = &cs47l85_remove, 2721 + .remove_new = cs47l85_remove, 2720 2722 }; 2721 2723 2722 2724 module_platform_driver(cs47l85_codec_driver);