Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

perf test: Stat output per thread of just the parent process

Per-thread mode requires either system-wide (-a), a pid (-p) or a tid
(-t).

The stat output tests were using system-wide mode but this is racy when
threads are starting and exiting - something that happens a lot when
running the tests in parallel (perf test -p).

Avoid the race conditions by using pid mode with the pid of the parent
process.

Signed-off-by: Ian Rogers <irogers@google.com>
Cc: Adrian Hunter <adrian.hunter@intel.com>
Cc: Alexander Shishkin <alexander.shishkin@linux.intel.com>
Cc: Athira Rajeev <atrajeev@linux.vnet.ibm.com>
Cc: Christian Brauner <brauner@kernel.org>
Cc: Disha Goel <disgoel@linux.ibm.com>
Cc: Ingo Molnar <mingo@redhat.com>
Cc: James Clark <james.clark@arm.com>
Cc: Jiri Olsa <jolsa@kernel.org>
Cc: K Prateek Nayak <kprateek.nayak@amd.com>
Cc: Kajol Jain <kjain@linux.ibm.com>
Cc: Kan Liang <kan.liang@linux.intel.com>
Cc: Mark Rutland <mark.rutland@arm.com>
Cc: Namhyung Kim <namhyung@kernel.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Song Liu <songliubraving@fb.com>
Cc: Tim Chen <tim.c.chen@linux.intel.com>
Cc: Yicong Yang <yangyicong@hisilicon.com>
Link: https://lore.kernel.org/r/20240301074639.2260708-2-irogers@google.com
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>

authored by

Ian Rogers and committed by
Arnaldo Carvalho de Melo
f68c981b 88ce0106

+2 -2
+1 -1
tools/perf/tests/shell/lib/stat_output.sh
··· 79 79 echo "[Skip] paranoid and not root" 80 80 return 81 81 fi 82 - perf stat --per-thread -a $2 true 82 + perf stat --per-thread -p $$ $2 true 83 83 commachecker --per-thread 84 84 echo "[Success]" 85 85 }
+1 -1
tools/perf/tests/shell/stat+json_output.sh
··· 105 105 echo "[Skip] paranoia and not root" 106 106 return 107 107 fi 108 - perf stat -j --per-thread -a -o "${stat_output}" true 108 + perf stat -j --per-thread -p $$ -o "${stat_output}" true 109 109 $PYTHON $pythonchecker --per-thread --file "${stat_output}" 110 110 echo "[Success]" 111 111 }