Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

x86/asm: Use asm_inline() instead of asm() in clwb()

Use asm_inline() to instruct the compiler that the size of asm()
is the minimum size of one instruction, ignoring how many instructions
the compiler thinks it is. ALTERNATIVE macro that expands to several
pseudo directives causes instruction length estimate to count
more than 20 instructions.

bloat-o-meter reports slight increase of the code size
for x86_64 defconfig object file, compiled with gcc-14.2:

add/remove: 0/2 grow/shrink: 3/0 up/down: 190/-59 (131)

Function old new delta
__copy_user_flushcache 166 247 +81
__memcpy_flushcache 369 437 +68
arch_wb_cache_pmem 6 47 +41
__pfx_clean_cache_range 16 - -16
clean_cache_range 43 - -43

Total: Before=22807167, After=22807298, chg +0.00%

The compiler now inlines and removes the clean_cache_range() function.

Signed-off-by: Uros Bizjak <ubizjak@gmail.com>
Signed-off-by: Ingo Molnar <mingo@kernel.org>
Cc: Andy Lutomirski <luto@kernel.org>
Cc: Brian Gerst <brgerst@gmail.com>
Cc: H. Peter Anvin <hpa@zytor.com>
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Link: https://lore.kernel.org/r/20250313102715.333142-2-ubizjak@gmail.com

authored by

Uros Bizjak and committed by
Ingo Molnar
f685a96b 53286632

+1 -1
+1 -1
arch/x86/include/asm/special_insns.h
··· 185 185 { 186 186 volatile struct { char x[64]; } *p = __p; 187 187 188 - asm volatile(ALTERNATIVE_2( 188 + asm_inline volatile(ALTERNATIVE_2( 189 189 "ds clflush %0", 190 190 "clflushopt %0", X86_FEATURE_CLFLUSHOPT, 191 191 "clwb %0", X86_FEATURE_CLWB)