Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

drm: bridge: cdns-mhdp8546: Fix PM reference leak in

pm_runtime_get_sync will increment pm usage counter even it failed.
Forgetting to putting operation will result in reference leak here.
Fix it by replacing it with pm_runtime_resume_and_get to keep usage
counter balanced.

Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Yu Kuai <yukuai3@huawei.com>
Reviewed-by: Robert Foss <robert.foss@linaro.org>
Signed-off-by: Robert Foss <robert.foss@linaro.org>
Link: https://patchwork.freedesktop.org/patch/msgid/20210531135622.3348252-1-yukuai3@huawei.com

authored by

Yu Kuai and committed by
Robert Foss
f674555e ef9e57cd

+2 -2
+2 -2
drivers/gpu/drm/bridge/cadence/cdns-mhdp8546-core.c
··· 2478 2478 clk_prepare_enable(clk); 2479 2479 2480 2480 pm_runtime_enable(dev); 2481 - ret = pm_runtime_get_sync(dev); 2481 + ret = pm_runtime_resume_and_get(dev); 2482 2482 if (ret < 0) { 2483 - dev_err(dev, "pm_runtime_get_sync failed\n"); 2483 + dev_err(dev, "pm_runtime_resume_and_get failed\n"); 2484 2484 pm_runtime_disable(dev); 2485 2485 goto clk_disable; 2486 2486 }