Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

net: enetc: clean up before returning in probe()

We recently added this error path. We need to call enetc_pci_remove()
before returning. It cleans up the resources from enetc_pci_probe().

Fixes: 99100d0d9922 ("net: enetc: add preliminary support for i.MX95 ENETC PF")
Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
Reviewed-by: Wei Fang <wei.fang@nxp.com>
Link: https://patch.msgid.link/93888efa-c838-4682-a7e5-e6bf318e844e@stanley.mountain
Signed-off-by: Jakub Kicinski <kuba@kernel.org>

authored by

Dan Carpenter and committed by
Jakub Kicinski
f66af961 575092a7

+5 -3
+5 -3
drivers/net/ethernet/freescale/enetc/enetc_vf.c
··· 174 174 si = pci_get_drvdata(pdev); 175 175 si->revision = ENETC_REV_1_0; 176 176 err = enetc_get_driver_data(si); 177 - if (err) 178 - return dev_err_probe(&pdev->dev, err, 179 - "Could not get VF driver data\n"); 177 + if (err) { 178 + dev_err_probe(&pdev->dev, err, 179 + "Could not get VF driver data\n"); 180 + goto err_alloc_netdev; 181 + } 180 182 181 183 enetc_get_si_caps(si); 182 184