Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

tools/latency-collector: Use correct size when writing queue_full_warning

queue_full_warning is a pointer, so it is wrong to use sizeof to calculate
the number of characters of the string it points to. The effect is that we
only print out the first few characters of the warning string.

The correct way is to use strlen(). We don't need to add 1 to the strlen()
because we don't want to write the terminating null character to stdout.

Link: https://lkml.kernel.org/r/20211019160701.15587-1-Viktor.Rosendahl@bmw.de

Link: https://lore.kernel.org/r/8fd4bb65ef3da67feac9ce3258cdbe9824752cf1.1629198502.git.jing.yangyang@zte.com.cn
Link: https://lore.kernel.org/r/20211012025424.180781-1-davidcomponentone@gmail.com
Reported-by: Zeal Robot <zealci@zte.com.cn>
Signed-off-by: Viktor Rosendahl <Viktor.Rosendahl@bmw.de>
Signed-off-by: Steven Rostedt (VMware) <rostedt@goodmis.org>

authored by

Viktor Rosendahl and committed by
Steven Rostedt (VMware)
f604de20 172f7ba9

+1 -1
+1 -1
tools/tracing/latency/latency-collector.c
··· 1538 1538 mutex_lock(&print_mtx); 1539 1539 check_signals(); 1540 1540 write_or_die(fd_stdout, queue_full_warning, 1541 - sizeof(queue_full_warning)); 1541 + strlen(queue_full_warning)); 1542 1542 mutex_unlock(&print_mtx); 1543 1543 } 1544 1544 modified--;