Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

V4L/DVB (13809): Fix Checkpatch violations

Signed-off-by: Manu Abraham <manu@linuxtv.org>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>

authored by

Manu Abraham and committed by
Mauro Carvalho Chehab
f5ae4f6f 1e42dc78

+155 -144
+58 -51
drivers/media/dvb/frontends/mb86a16.c
··· 37 37 const struct mb86a16_config *config; 38 38 struct dvb_frontend frontend; 39 39 40 - // tuning parameters 40 + /* tuning parameters */ 41 41 int frequency; 42 42 int srate; 43 43 44 - // Internal stuff 44 + /* Internal stuff */ 45 45 int master_clk; 46 46 int deci; 47 47 int csel; ··· 105 105 .flags = 0, 106 106 .buf = b0, 107 107 .len = 1 108 - },{ 108 + }, { 109 109 .addr = state->config->demod_address, 110 110 .flags = I2C_M_RD, 111 111 .buf = b1, ··· 435 435 wait_sym = 80000; 436 436 } 437 437 for (i = 0; i < 3; i++) { 438 - if (i == 0 ) 438 + if (i == 0) 439 439 smrtd = smrt * 98 / 100; 440 440 else if (i == 1) 441 441 smrtd = smrt; ··· 480 480 unsigned char rf_val[5]; 481 481 int ack = -1; 482 482 483 - if (smrt > 37750 ) 483 + if (smrt > 37750) 484 484 C = 1; 485 485 else if (smrt > 18875) 486 486 C = 2; 487 - else if (smrt > 5500 ) 487 + else if (smrt > 5500) 488 488 C = 3; 489 489 else 490 490 C = 4; ··· 526 526 rf_val[2] = (M & 0x00ff0) >> 4; 527 527 rf_val[3] = ((M & 0x0000f) << 4) | B; 528 528 529 - // Frequency Set 529 + /* Frequency Set */ 530 530 if (mb86a16_write(state, 0x21, rf_val[0]) < 0) 531 531 ack = 0; 532 532 if (mb86a16_write(state, 0x22, rf_val[1]) < 0) ··· 655 655 unsigned char CRM, AFCML, AFCMH; 656 656 unsigned char temp1, temp2, temp3; 657 657 int crm, afcm, AFCM; 658 - int crrerr, afcerr; // [kHz] 659 - int frqerr; // [MHz] 658 + int crrerr, afcerr; /* kHz */ 659 + int frqerr; /* MHz */ 660 660 int afcen, afcexen = 0; 661 661 int R, M, fOSC, fOSC_OFS; 662 662 ··· 718 718 719 719 fOSC_OFS = fOSC - fTP; 720 720 721 - if (unit == 0) { //[MHz] 721 + if (unit == 0) { /* MHz */ 722 722 if (crrerr + afcerr + fOSC_OFS * 1000 >= 0) 723 723 frqerr = (crrerr + afcerr + fOSC_OFS * 1000 + 500) / 1000; 724 724 else 725 725 frqerr = (crrerr + afcerr + fOSC_OFS * 1000 - 500) / 1000; 726 - } else { //[kHz] 726 + } else { /* kHz */ 727 727 frqerr = crrerr + afcerr + fOSC_OFS * 1000; 728 728 } 729 729 ··· 760 760 761 761 crnt_swp_freq = fOSC_start * 1000 + v * swp_ofs; 762 762 763 - if (R == 0 ) 763 + if (R == 0) 764 764 *fOSC = (crnt_swp_freq + 1000) / 2000 * 2; 765 765 else 766 766 *fOSC = (crnt_swp_freq + 500) / 1000; 767 767 768 768 if (*fOSC >= crnt_swp_freq) 769 - *afcex_freq = *fOSC *1000 - crnt_swp_freq; 769 + *afcex_freq = *fOSC * 1000 - crnt_swp_freq; 770 770 else 771 771 *afcex_freq = crnt_swp_freq - *fOSC * 1000; 772 772 ··· 782 782 int swp_freq ; 783 783 784 784 if ((i % 2 == 1) && (v <= vmax)) { 785 - // positive v (case 1) 785 + /* positive v (case 1) */ 786 786 if ((v - 1 == vmin) && 787 787 (*(V + 30 + v) >= 0) && 788 788 (*(V + 30 + v - 1) >= 0) && ··· 796 796 (*(V + 30 + v - 1) >= 0) && 797 797 (*(V + 30 + v) > *(V + 30 + v - 1)) && 798 798 (*(V + 30 + v) > SIGMIN)) { 799 - // (case 2) 799 + /* (case 2) */ 800 800 swp_freq = fOSC * 1000 + afcex_freq; 801 801 *SIG1 = *(V + 30 + v); 802 802 } else if ((*(V + 30 + v) > 0) && ··· 807 807 (*(V + 30 + v - 2) > *(V + 30 + v - 3)) && 808 808 ((*(V + 30 + v - 1) > SIGMIN) || 809 809 (*(V + 30 + v - 2) > SIGMIN))) { 810 - // (case 3) 810 + /* (case 3) */ 811 811 if (*(V + 30 + v - 1) >= *(V + 30 + v - 2)) { 812 812 swp_freq = fOSC * 1000 + afcex_freq - swp_ofs; 813 813 *SIG1 = *(V + 30 + v - 1); ··· 823 823 (*(V + 30 + v - 1) > *(V + 30 + v - 2)) && 824 824 ((*(V + 30 + v) > SIGMIN) || 825 825 (*(V + 30 + v - 1) > SIGMIN))) { 826 - // (case 4) 826 + /* (case 4) */ 827 827 if (*(V + 30 + v) >= *(V + 30 + v - 1)) { 828 828 swp_freq = fOSC * 1000 + afcex_freq; 829 829 *SIG1 = *(V + 30 + v); ··· 835 835 swp_freq = -1 ; 836 836 } 837 837 } else if ((i % 2 == 0) && (v >= vmin)) { 838 - // Negative v (case 1) 838 + /* Negative v (case 1) */ 839 839 if ((*(V + 30 + v) > 0) && 840 840 (*(V + 30 + v + 1) > 0) && 841 841 (*(V + 30 + v + 2) > 0) && ··· 850 850 (*(V + 30 + v + 1) >= 0) && 851 851 (*(V + 30 + v + 1) > *(V + 30 + v)) && 852 852 (*(V + 30 + v + 1) > SIGMIN)) { 853 - // (case 2) 853 + /* (case 2) */ 854 854 swp_freq = fOSC * 1000 + afcex_freq + swp_ofs; 855 855 *SIG1 = *(V + 30 + v); 856 856 } else if ((v == vmin) && ··· 860 860 (*(V + 30 + v) > *(V + 30 + v + 1)) && 861 861 (*(V + 30 + v) > *(V + 30 + v + 2)) && 862 862 (*(V + 30 + v) > SIGMIN)) { 863 - // (case 3) 863 + /* (case 3) */ 864 864 swp_freq = fOSC * 1000 + afcex_freq; 865 865 *SIG1 = *(V + 30 + v); 866 866 } else if ((*(V + 30 + v) >= 0) && 867 867 (*(V + 30 + v + 1) >= 0) && 868 868 (*(V + 30 + v + 2) >= 0) && 869 - (*(V +30 + v + 3) >= 0) && 869 + (*(V + 30 + v + 3) >= 0) && 870 870 (*(V + 30 + v + 1) > *(V + 30 + v)) && 871 871 (*(V + 30 + v + 2) > *(V + 30 + v + 3)) && 872 872 ((*(V + 30 + v + 1) > SIGMIN) || 873 873 (*(V + 30 + v + 2) > SIGMIN))) { 874 - // (case 4) 874 + /* (case 4) */ 875 875 if (*(V + 30 + v + 1) >= *(V + 30 + v + 2)) { 876 876 swp_freq = fOSC * 1000 + afcex_freq + swp_ofs; 877 877 *SIG1 = *(V + 30 + v + 1); ··· 889 889 (*(V + 30 + v + 1) > *(V + 30 + v + 3)) && 890 890 ((*(V + 30 + v) > SIGMIN) || 891 891 (*(V + 30 + v + 1) > SIGMIN))) { 892 - // (case 5) 892 + /* (case 5) */ 893 893 if (*(V + 30 + v) >= *(V + 30 + v + 1)) { 894 894 swp_freq = fOSC * 1000 + afcex_freq; 895 895 *SIG1 = *(V + 30 + v); ··· 905 905 (*(V + 30 + v + 2) > *(V + 30 + v)) && 906 906 ((*(V + 30 + v + 1) > SIGMIN) || 907 907 (*(V + 30 + v + 2) > SIGMIN))) { 908 - // (case 6) 908 + /* (case 6) */ 909 909 if (*(V + 30 + v + 1) >= *(V + 30 + v + 2)) { 910 910 swp_freq = fOSC * 1000 + afcex_freq + swp_ofs; 911 911 *SIG1 = *(V + 30 + v + 1); ··· 916 916 } else if ((vmax == 0) && (vmin == 0) && (*(V + 30 + v) > SIGMIN)) { 917 917 swp_freq = fOSC * 1000; 918 918 *SIG1 = *(V + 30 + v); 919 - } else swp_freq = -1; 920 - } else swp_freq = -1; 919 + } else 920 + swp_freq = -1; 921 + } else 922 + swp_freq = -1; 921 923 922 924 return swp_freq; 923 925 } ··· 964 962 965 963 static int SEQ_set(struct mb86a16_state *state, unsigned char loop) 966 964 { 967 - // SLOCK0 = 0 965 + /* SLOCK0 = 0 */ 968 966 if (mb86a16_write(state, 0x32, 0x02 | (loop << 2)) < 0) { 969 967 dprintk(verbose, MB86A16_ERROR, 1, "I2C transfer error"); 970 968 return -EREMOTEIO; ··· 975 973 976 974 static int iq_vt_set(struct mb86a16_state *state, unsigned char IQINV) 977 975 { 978 - // Viterbi Rate, IQ Settings 976 + /* Viterbi Rate, IQ Settings */ 979 977 if (mb86a16_write(state, 0x06, 0xdf | (IQINV << 5)) < 0) { 980 978 dprintk(verbose, MB86A16_ERROR, 1, "I2C transfer error"); 981 979 return -EREMOTEIO; ··· 1033 1031 unsigned char TIMINT1, TIMINT2, TIMEXT; 1034 1032 unsigned char S0T, S1T; 1035 1033 unsigned char S2T; 1036 - // unsigned char S2T, S3T; 1034 + /* unsigned char S2T, S3T; */ 1037 1035 unsigned char S4T, S5T; 1038 1036 unsigned char AFCEX_L, AFCEX_H; 1039 1037 unsigned char R; ··· 1054 1052 int temp_freq, delta_freq; 1055 1053 int dagcm[4]; 1056 1054 int smrt_d; 1057 - // int freq_err; 1055 + /* int freq_err; */ 1058 1056 int n; 1059 1057 int ret = -1; 1060 1058 int sync; ··· 1095 1093 } 1096 1094 if (EN_set(state, CREN, AFCEN) < 0) { 1097 1095 dprintk(verbose, MB86A16_ERROR, 1, "EN set error"); 1098 - return -1; // (0, 0) 1096 + return -1; /* (0, 0) */ 1099 1097 } 1100 1098 if (AFCEXEN_set(state, AFCEXEN, state->srate) < 0) { 1101 1099 dprintk(verbose, MB86A16_ERROR, 1, "AFCEXEN set error"); 1102 - return -1; // (1, smrt) = (1, symbolrate) 1100 + return -1; /* (1, smrt) = (1, symbolrate) */ 1103 1101 } 1104 1102 if (CNTM_set(state, TIMINT1, TIMINT2, TIMEXT) < 0) { 1105 1103 dprintk(verbose, MB86A16_ERROR, 1, "CNTM set error"); 1106 - return -1; // (0, 1, 2) 1104 + return -1; /* (0, 1, 2) */ 1107 1105 } 1108 1106 if (S01T_set(state, S1T, S0T) < 0) { 1109 1107 dprintk(verbose, MB86A16_ERROR, 1, "S01T set error"); 1110 - return -1; // (0, 0) 1108 + return -1; /* (0, 0) */ 1111 1109 } 1112 1110 smrt_info_get(state, state->srate); 1113 1111 if (smrt_set(state, state->srate) < 0) { ··· 1135 1133 ftemp = ftemp + swp_ofs; 1136 1134 vmax++; 1137 1135 1138 - // Upper bound 1136 + /* Upper bound */ 1139 1137 if (ftemp > 2150000) { 1140 1138 loop = 0; 1141 1139 vmax--; 1140 + } else { 1141 + if ((ftemp == 2150000) || 1142 + (ftemp - state->frequency * 1000 >= fcp + state->srate / 4)) 1143 + loop = 0; 1142 1144 } 1143 - else if ((ftemp == 2150000) || (ftemp - state->frequency * 1000 >= fcp + state->srate / 4)) 1144 - loop = 0; 1145 1145 } 1146 1146 1147 1147 loop = 1; ··· 1153 1149 ftemp = ftemp - swp_ofs; 1154 1150 vmin--; 1155 1151 1156 - // Lower bound 1152 + /* Lower bound */ 1157 1153 if (ftemp < 950000) { 1158 1154 loop = 0; 1159 1155 vmin++; 1156 + } else { 1157 + if ((ftemp == 950000) || 1158 + (state->frequency * 1000 - ftemp >= fcp + state->srate / 4)) 1159 + loop = 0; 1160 1160 } 1161 - else if ((ftemp == 950000) || (state->frequency * 1000 - ftemp >= fcp + state->srate / 4)) 1162 - loop = 0; 1163 1161 } 1164 1162 1165 1163 wait_t = (8000 + state->srate / 2) / state->srate; ··· 1205 1199 V[30 + v] = SIG1 ; 1206 1200 swp_freq = swp_freq_calcuation(state, i, v, V, vmax, vmin, 1207 1201 SIG1MIN, fOSC, afcex_freq, 1208 - swp_ofs, &SIG1); //changed 1202 + swp_ofs, &SIG1); /* changed */ 1209 1203 1210 1204 signal_dupl = 0; 1211 1205 for (j = 0; j < prev_freq_num; j++) { ··· 1297 1291 dprintk(verbose, MB86A16_ERROR, 1, "srst error"); 1298 1292 return -1; 1299 1293 } 1300 - // delay 4~200 1294 + /* delay 4~200 */ 1301 1295 wait_t = 200000 / state->master_clk + 200000 / state->srate; 1302 1296 msleep(wait_t); 1303 1297 afcerr = afcerr_chk(state); ··· 1458 1452 S2T = 7; S4T = 2; S5T = 8; ETH = 7; VIA = 2; 1459 1453 wait_t = 7 + (2097152 + state->srate / 2) / state->srate; 1460 1454 } 1461 - wait_t *= 2; /* FOS */ 1455 + wait_t *= 2; /* FOS */ 1462 1456 S2T_set(state, S2T); 1463 1457 S45T_set(state, S4T, S5T); 1464 1458 Vi_set(state, ETH, VIA); ··· 1467 1461 sync = sync_chk(state, &VIRM); 1468 1462 dprintk(verbose, MB86A16_INFO, 1, "-------- Viterbi=[%d] SYNC=[%d] ---------", VIRM, sync); 1469 1463 if (VIRM) { 1470 - if (VIRM == 4) { // 5/6 1464 + if (VIRM == 4) { 1465 + /* 5/6 */ 1471 1466 if (SIG1 > 110) 1472 - wait_t = ( 786432 + state->srate / 2) / state->srate; 1467 + wait_t = (786432 + state->srate / 2) / state->srate; 1473 1468 else 1474 1469 wait_t = (1572864 + state->srate / 2) / state->srate; 1475 1470 if (state->srate < 5000) 1476 - // FIXME ! , should be a long wait ! 1471 + /* FIXME ! , should be a long wait ! */ 1477 1472 msleep_interruptible(wait_t); 1478 1473 else 1479 1474 msleep_interruptible(wait_t); ··· 1484 1477 FEC_srst(state); 1485 1478 } 1486 1479 } 1487 - // 1/2, 2/3, 3/4, 7/8 1480 + /* 1/2, 2/3, 3/4, 7/8 */ 1488 1481 if (SIG1 > 110) 1489 - wait_t = ( 786432 + state->srate / 2) / state->srate; 1482 + wait_t = (786432 + state->srate / 2) / state->srate; 1490 1483 else 1491 1484 wait_t = (1572864 + state->srate / 2) / state->srate; 1492 1485 msleep_interruptible(wait_t); ··· 1498 1491 } 1499 1492 } 1500 1493 } else { 1501 - dprintk (verbose, MB86A16_INFO, 1, "NO -- SIGNAL"); 1494 + dprintk(verbose, MB86A16_INFO, 1, "NO -- SIGNAL"); 1502 1495 ret = -1; 1503 1496 } 1504 1497 ··· 1853 1846 u8 dev_id = 0; 1854 1847 struct mb86a16_state *state = NULL; 1855 1848 1856 - state = kmalloc(sizeof (struct mb86a16_state), GFP_KERNEL); 1849 + state = kmalloc(sizeof(struct mb86a16_state), GFP_KERNEL); 1857 1850 if (state == NULL) 1858 1851 goto error; 1859 1852 ··· 1864 1857 if (dev_id != 0xfe) 1865 1858 goto error; 1866 1859 1867 - memcpy(&state->frontend.ops, &mb86a16_ops, sizeof (struct dvb_frontend_ops)); 1860 + memcpy(&state->frontend.ops, &mb86a16_ops, sizeof(struct dvb_frontend_ops)); 1868 1861 state->frontend.demodulator_priv = state; 1869 1862 state->frontend.ops.set_voltage = state->config->set_voltage; 1870 1863
+1 -1
drivers/media/dvb/frontends/mb86a16.h
··· 35 35 struct i2c_adapter *i2c_adap); 36 36 37 37 38 - #endif //__MB86A16_H 38 + #endif /* __MB86A16_H */
+1 -1
drivers/media/dvb/frontends/mb86a16_priv.h
··· 148 148 #define MB86A16_DISTMON 0x52 149 149 #define MB86A16_VERSION 0x7f 150 150 151 - #endif //__MB86A16_PRIV_H 151 + #endif /* __MB86A16_PRIV_H */
+16 -16
drivers/media/dvb/frontends/tda665x.c
··· 45 45 46 46 return err; 47 47 exit: 48 - printk("%s: I/O Error err=<%d>\n", __func__, err); 48 + printk(KERN_ERR "%s: I/O Error err=<%d>\n", __func__, err); 49 49 return err; 50 50 } 51 51 ··· 61 61 62 62 return err; 63 63 exit: 64 - printk("%s: I/O Error err=<%d>\n", __func__, err); 64 + printk(KERN_ERR "%s: I/O Error err=<%d>\n", __func__, err); 65 65 return err; 66 66 } 67 67 ··· 79 79 case DVBFE_TUNER_BANDWIDTH: 80 80 break; 81 81 default: 82 - printk("%s: Unknown parameter (param=%d)\n", __func__, param); 82 + printk(KERN_ERR "%s: Unknown parameter (param=%d)\n", __func__, param); 83 83 err = -EINVAL; 84 84 break; 85 85 } ··· 100 100 goto exit; 101 101 102 102 if ((result >> 6) & 0x01) { 103 - printk("%s: Tuner Phase Locked\n", __func__); 103 + printk(KERN_DEBUG "%s: Tuner Phase Locked\n", __func__); 104 104 *status = 1; 105 105 } 106 106 107 107 return err; 108 108 exit: 109 - printk("%s: I/O Error\n", __func__); 109 + printk(KERN_ERR "%s: I/O Error\n", __func__); 110 110 return err; 111 111 } 112 112 ··· 124 124 125 125 frequency = tstate->frequency; 126 126 if ((frequency < config->frequency_max) || (frequency > config->frequency_min)) { 127 - printk("%s: Frequency beyond limits, frequency=%d\n", __func__, frequency); 127 + printk(KERN_ERR "%s: Frequency beyond limits, frequency=%d\n", __func__, frequency); 128 128 return -EINVAL; 129 129 } 130 130 ··· 133 133 frequency += config->ref_divider >> 1; 134 134 frequency /= config->ref_divider; 135 135 136 - buf[0] = (u8 ) (frequency & 0x7f00) >> 8; 137 - buf[1] = (u8 ) (frequency & 0x00ff) >> 0; 136 + buf[0] = (u8) (frequency & 0x7f00) >> 8; 137 + buf[1] = (u8) (frequency & 0x00ff) >> 0; 138 138 buf[2] = 0x80 | 0x40 | 0x02; 139 139 buf[3] = 0x00; 140 140 ··· 178 178 goto exit; 179 179 180 180 /* sleep for some time */ 181 - printk("%s: Waiting to Phase LOCK\n", __func__); 181 + printk(KERN_DEBUG "%s: Waiting to Phase LOCK\n", __func__); 182 182 msleep(20); 183 183 /* check status */ 184 184 err = tda665x_get_status(fe, &status); ··· 186 186 goto exit; 187 187 188 188 if (status == 1) { 189 - printk("%s: Tuner Phase locked: status=%d\n", __func__, status); 189 + printk(KERN_DEBUG "%s: Tuner Phase locked: status=%d\n", __func__, status); 190 190 state->frequency = frequency; /* cache successful state */ 191 191 } else { 192 - printk("%s: No Phase lock: status=%d\n", __func__, status); 192 + printk(KERN_ERR "%s: No Phase lock: status=%d\n", __func__, status); 193 193 } 194 194 } else { 195 - printk("%s: Unknown parameter (param=%d)\n", __func__, param); 195 + printk(KERN_ERR "%s: Unknown parameter (param=%d)\n", __func__, param); 196 196 return -EINVAL; 197 197 } 198 198 199 199 return 0; 200 200 exit: 201 - printk("%s: I/O Error\n", __func__); 201 + printk(KERN_ERR "%s: I/O Error\n", __func__); 202 202 return err; 203 203 } 204 204 ··· 226 226 struct tda665x_state *state = NULL; 227 227 struct dvb_tuner_info *info; 228 228 229 - state = kzalloc(sizeof (struct tda665x_state), GFP_KERNEL); 229 + state = kzalloc(sizeof(struct tda665x_state), GFP_KERNEL); 230 230 if (state == NULL) 231 231 goto exit; 232 232 ··· 237 237 fe->ops.tuner_ops = tda665x_ops; 238 238 info = &fe->ops.tuner_ops.info; 239 239 240 - memcpy(info->name, config->name, sizeof (config->name)); 240 + memcpy(info->name, config->name, sizeof(config->name)); 241 241 info->frequency_min = config->frequency_min; 242 242 info->frequency_max = config->frequency_max; 243 243 info->frequency_step = config->frequency_offst; 244 244 245 - printk("%s: Attaching TDA665x (%s) tuner\n", __func__, info->name); 245 + printk(KERN_DEBUG "%s: Attaching TDA665x (%s) tuner\n", __func__, info->name); 246 246 247 247 return fe; 248 248
+1 -1
drivers/media/dvb/frontends/tda665x.h
··· 40 40 #else 41 41 42 42 static inline struct dvb_frontend *tda665x_attach(struct dvb_frontend *fe, 43 - const struct tda665x_config *config, 43 + const struct tda665x_config *config, 44 44 struct i2c_adapter *i2c) 45 45 { 46 46 printk(KERN_WARNING "%s: Driver disabled by Kconfig\n", __func__);
+1 -1
drivers/media/dvb/mantis/hopper_cards.c
··· 137 137 struct mantis_hwconfig *config; 138 138 int err = 0; 139 139 140 - mantis = kzalloc(sizeof (struct mantis_pci), GFP_KERNEL); 140 + mantis = kzalloc(sizeof(struct mantis_pci), GFP_KERNEL); 141 141 if (mantis == NULL) { 142 142 printk(KERN_ERR "%s ERROR: Out of memory\n", __func__); 143 143 err = -ENOMEM;
+2 -2
drivers/media/dvb/mantis/mantis_ca.c
··· 119 119 struct mantis_pci *mantis = ca->ca_priv; 120 120 121 121 dprintk(MANTIS_DEBUG, 1, "Slot(%d): TS control", slot); 122 - // mantis_set_direction(mantis, 1); /* Enable TS through CAM */ 122 + /* mantis_set_direction(mantis, 1); */ /* Enable TS through CAM */ 123 123 124 124 return 0; 125 125 } ··· 148 148 int ca_flags = 0, result; 149 149 150 150 dprintk(MANTIS_DEBUG, 1, "Initializing Mantis CA"); 151 - ca = kzalloc(sizeof (struct mantis_ca), GFP_KERNEL); 151 + ca = kzalloc(sizeof(struct mantis_ca), GFP_KERNEL); 152 152 if (!ca) { 153 153 dprintk(MANTIS_ERROR, 1, "Out of memory!, exiting .."); 154 154 result = -ENOMEM;
+1 -1
drivers/media/dvb/mantis/mantis_cards.c
··· 145 145 struct mantis_hwconfig *config; 146 146 int err = 0; 147 147 148 - mantis = kzalloc(sizeof (struct mantis_pci), GFP_KERNEL); 148 + mantis = kzalloc(sizeof(struct mantis_pci), GFP_KERNEL); 149 149 if (mantis == NULL) { 150 150 printk(KERN_ERR "%s ERROR: Out of memory\n", __func__); 151 151 err = -ENOMEM;
+29 -19
drivers/media/dvb/mantis/mantis_core.c
··· 36 36 .flags = 0, 37 37 .buf = data, 38 38 .len = 1 39 - },{ 39 + }, { 40 40 .addr = 0x50, 41 41 .flags = I2C_M_RD, 42 42 .buf = data, 43 43 .len = length 44 44 }, 45 45 }; 46 - if ((err = i2c_transfer(&mantis->adapter, msg, 2)) < 0) { 46 + 47 + err = i2c_transfer(&mantis->adapter, msg, 2); 48 + if (err < 0) { 47 49 dprintk(verbose, MANTIS_ERROR, 1, 48 50 "ERROR: i2c read: < err=%i d0=0x%02x d1=0x%02x >", 49 51 err, data[0], data[1]); ··· 67 65 .len = length 68 66 }; 69 67 70 - if ((err = i2c_transfer(&mantis->adapter, &msg, 1)) < 0) { 68 + err = i2c_transfer(&mantis->adapter, &msg, 1); 69 + if (err < 0) { 71 70 dprintk(verbose, MANTIS_ERROR, 1, 72 71 "ERROR: i2c write: < err=%i length=0x%02x d0=0x%02x, d1=0x%02x >", 73 72 err, length, data[0], data[1]); ··· 84 81 int err; 85 82 86 83 mantis->mac_address[0] = 0x08; 87 - if ((err = read_eeprom_byte(mantis, &mantis->mac_address[0], 6)) < 0) { 84 + err = read_eeprom_byte(mantis, &mantis->mac_address[0], 6); 85 + if (err < 0) { 88 86 dprintk(verbose, MANTIS_ERROR, 1, "Mantis EEPROM read error"); 89 87 90 88 return err; ··· 110 106 static void mantis_load_config(struct mantis_pci *mantis) 111 107 { 112 108 switch (mantis->subsystem_device) { 113 - case MANTIS_VP_1033_DVB_S: // VP-1033 109 + case MANTIS_VP_1033_DVB_S: /* VP-1033 */ 114 110 mantis->hwconfig = &vp1033_mantis_config; 115 111 break; 116 - case MANTIS_VP_1034_DVB_S: // VP-1034 112 + case MANTIS_VP_1034_DVB_S: /* VP-1034 */ 117 113 mantis->hwconfig = &vp1034_mantis_config; 118 114 break; 119 - case MANTIS_VP_1041_DVB_S2: // VP-1041 115 + case MANTIS_VP_1041_DVB_S2: /* VP-1041 */ 120 116 case TECHNISAT_SKYSTAR_HD2: 121 117 mantis->hwconfig = &vp1041_mantis_config; 122 118 break; 123 - case MANTIS_VP_2033_DVB_C: // VP-2033 119 + case MANTIS_VP_2033_DVB_C: /* VP-2033 */ 124 120 mantis->hwconfig = &vp2033_mantis_config; 125 121 break; 126 - case MANTIS_VP_2040_DVB_C: // VP-2040 127 - case TERRATEC_CINERGY_C_PCI: // VP-2040 clone 122 + case MANTIS_VP_2040_DVB_C: /* VP-2040 */ 123 + case TERRATEC_CINERGY_C_PCI: /* VP-2040 clone */ 128 124 case TECHNISAT_CABLESTAR_HD2: 129 125 mantis->hwconfig = &vp2040_mantis_config; 130 126 break; 131 - case MANTIS_VP_3030_DVB_T: // VP-3030 127 + case MANTIS_VP_3030_DVB_T: /* VP-3030 */ 132 128 mantis->hwconfig = &vp3030_mantis_config; 133 129 break; 134 130 default: ··· 153 149 mantis->pdev->irq, mantis->latency, 154 150 mantis->mantis_addr, mantis->mantis_mmio); 155 151 156 - if ((err = mantis_i2c_init(mantis)) < 0) { 152 + err = mantis_i2c_init(mantis); 153 + if (err < 0) { 157 154 dprintk(verbose, MANTIS_ERROR, 1, "Mantis I2C init failed"); 158 155 return err; 159 156 } 160 - if ((err = get_mac_address(mantis)) < 0) { 157 + err = get_mac_address(mantis); 158 + if (err < 0) { 161 159 dprintk(verbose, MANTIS_ERROR, 1, "get MAC address failed"); 162 160 return err; 163 161 } 164 - if ((err = mantis_dma_init(mantis)) < 0) { 162 + err = mantis_dma_init(mantis); 163 + if (err < 0) { 165 164 dprintk(verbose, MANTIS_ERROR, 1, "Mantis DMA init failed"); 166 165 return err; 167 166 } 168 - if ((err = mantis_dvb_init(mantis)) < 0) { 167 + err = mantis_dvb_init(mantis); 168 + if (err < 0) { 169 169 dprintk(verbose, MANTIS_DEBUG, 1, "Mantis DVB init failed"); 170 170 return err; 171 171 } 172 - if ((err = mantis_uart_init(mantis)) < 0) { 172 + err = mantis_uart_init(mantis); 173 + if (err < 0) { 173 174 dprintk(verbose, MANTIS_DEBUG, 1, "Mantis UART init failed"); 174 175 return err; 175 176 } ··· 200 191 return 0; 201 192 } 202 193 203 - // Turn the given bit on or off. 194 + /* Turn the given bit on or off. */ 204 195 void gpio_set_bits(struct mantis_pci *mantis, u32 bitpos, u8 value) 205 196 { 206 197 u32 cur; ··· 216 207 udelay(100); 217 208 } 218 209 219 - //direction = 0 , no CI passthrough ; 1 , CI passthrough 210 + /* direction = 0 , no CI passthrough ; 1 , CI passthrough */ 220 211 void mantis_set_direction(struct mantis_pci *mantis, int direction) 221 212 { 222 213 u32 reg; 223 214 224 215 reg = mmread(0x28); 225 216 dprintk(verbose, MANTIS_DEBUG, 1, "TS direction setup"); 226 - if (direction == 0x01) { //to CI 217 + if (direction == 0x01) { 218 + /* to CI */ 227 219 reg |= 0x04; 228 220 mmwrite(reg, 0x28); 229 221 reg &= 0xff - 0x04;
+7 -7
drivers/media/dvb/mantis/mantis_core.h
··· 33 33 34 34 35 35 struct vendorname { 36 - __u8 *sub_vendor_name; 37 - __u32 sub_vendor_id; 36 + u8 *sub_vendor_name; 37 + u32 sub_vendor_id; 38 38 }; 39 39 40 40 struct devicetype { 41 - __u8 *sub_device_name; 42 - __u32 sub_device_id; 43 - __u8 device_type; 44 - __u32 type_flags; 41 + u8 *sub_device_name; 42 + u32 sub_device_id; 43 + u8 device_type; 44 + u32 type_flags; 45 45 }; 46 46 47 47 ··· 54 54 extern int mantis_core_init(struct mantis_pci *mantis); 55 55 extern int mantis_core_exit(struct mantis_pci *mantis); 56 56 57 - #endif //__MANTIS_CORE_H 57 + #endif /* __MANTIS_CORE_H */
+6 -5
drivers/media/dvb/mantis/mantis_dma.c
··· 43 43 #define RISC_IRQ (0x01 << 24) 44 44 45 45 #define RISC_STATUS(status) ((((~status) & 0x0f) << 20) | ((status & 0x0f) << 16)) 46 - #define RISC_FLUSH() mantis->risc_pos = 0 47 - #define RISC_INSTR(opcode) mantis->risc_cpu[mantis->risc_pos++] = cpu_to_le32(opcode) 46 + #define RISC_FLUSH() (mantis->risc_pos = 0) 47 + #define RISC_INSTR(opcode) (mantis->risc_cpu[mantis->risc_pos++] = cpu_to_le32(opcode)) 48 48 49 - #define MANTIS_BUF_SIZE 64 * 1024 49 + #define MANTIS_BUF_SIZE (64 * 1024) 50 50 #define MANTIS_BLOCK_BYTES (MANTIS_BUF_SIZE >> 4) 51 51 #define MANTIS_BLOCK_COUNT (1 << 4) 52 52 #define MANTIS_RISC_SIZE PAGE_SIZE ··· 158 158 159 159 goto err; 160 160 } 161 - if ((err = mantis_calc_lines(mantis)) < 0) { 161 + err = mantis_calc_lines(mantis); 162 + if (err < 0) { 162 163 dprintk(MANTIS_ERROR, 1, "Mantis calc lines failed"); 163 164 164 165 goto err; ··· 249 248 dprintk(MANTIS_DEBUG, 1, "last block=[%d] finished block=[%d]", 250 249 mantis->last_block, mantis->finished_block); 251 250 252 - (config->ts_size ? dvb_dmx_swfilter_204: dvb_dmx_swfilter) 251 + (config->ts_size ? dvb_dmx_swfilter_204 : dvb_dmx_swfilter) 253 252 (&mantis->demux, &mantis->buf_cpu[mantis->last_block * MANTIS_BLOCK_BYTES], MANTIS_BLOCK_BYTES); 254 253 mantis->last_block = (mantis->last_block + 1) % MANTIS_BLOCK_COUNT; 255 254 }
+3 -9
drivers/media/dvb/mantis/mantis_dvb.c
··· 116 116 117 117 if (mantis->feeds == 1) { 118 118 dprintk(MANTIS_DEBUG, 1, "mantis start feed & dma"); 119 - printk("mantis start feed & dma\n"); 120 119 mantis_dma_start(mantis); 121 120 } 122 121 ··· 136 137 mantis->feeds--; 137 138 if (mantis->feeds == 0) { 138 139 dprintk(MANTIS_DEBUG, 1, "mantis stop feed and dma"); 139 - printk("mantis stop feed and dma\n"); 140 140 mantis_dma_stop(mantis); 141 141 } 142 142 ··· 202 204 } 203 205 204 206 mantis->fe_mem.source = DMX_MEMORY_FE; 205 - result = mantis->demux.dmx.add_frontend(&mantis->demux.dmx,&mantis->fe_mem); 207 + result = mantis->demux.dmx.add_frontend(&mantis->demux.dmx, &mantis->fe_mem); 206 208 if (result < 0) { 207 - dprintk(MANTIS_ERROR, 1,"dvb_dmx_init failed, ERROR=%d", result); 209 + dprintk(MANTIS_ERROR, 1, "dvb_dmx_init failed, ERROR=%d", result); 208 210 goto err3; 209 211 } 210 212 ··· 222 224 dprintk(MANTIS_ERROR, 1, "!!! NO Frontends found !!!"); 223 225 goto err5; 224 226 } else { 225 - // if (mantis->dvb_adapter == NULL) { 226 - // dprintk(MANTIS_ERROR, 1, "DVB adapter <NULL>"); 227 - // goto err5; 228 - // } 229 227 if (mantis->fe == NULL) { 230 228 dprintk(MANTIS_ERROR, 1, "FE <NULL>"); 231 229 goto err5; ··· 271 277 int err; 272 278 273 279 if (mantis->fe) { 274 - // mantis_ca_exit(mantis); 280 + /* mantis_ca_exit(mantis); */ 275 281 err = mantis_frontend_shutdown(mantis); 276 282 if (err != 0) 277 283 dprintk(MANTIS_ERROR, 1, "Frontend exit while POWER ON! <%d>", err);
+1 -1
drivers/media/dvb/mantis/mantis_i2c.c
··· 225 225 226 226 init_waitqueue_head(&mantis->i2c_wq); 227 227 mutex_init(&mantis->i2c_lock); 228 - strncpy(i2c_adapter->name, "Mantis I2C", sizeof (i2c_adapter->name)); 228 + strncpy(i2c_adapter->name, "Mantis I2C", sizeof(i2c_adapter->name)); 229 229 i2c_set_adapdata(i2c_adapter, mantis); 230 230 231 231 i2c_adapter->owner = THIS_MODULE;
+14 -14
drivers/media/dvb/mantis/mantis_input.c
··· 36 36 { 0x29, KEY_POWER }, 37 37 { 0x28, KEY_FAVORITES }, 38 38 { 0x30, KEY_TEXT }, 39 - { 0x17, KEY_INFO }, // Preview 39 + { 0x17, KEY_INFO }, /* Preview */ 40 40 { 0x23, KEY_EPG }, 41 - { 0x3b, KEY_F22 },// Record List 41 + { 0x3b, KEY_F22 }, /* Record List */ 42 42 { 0x3c, KEY_1 }, 43 43 { 0x3e, KEY_2 }, 44 44 { 0x39, KEY_3 }, ··· 71 71 72 72 { 0x1f, KEY_REWIND }, 73 73 { 0x2d, KEY_FASTFORWARD }, 74 - { 0x1e, KEY_PREVIOUS }, // Replay |< 75 - { 0x1d, KEY_NEXT }, // Skip >| 74 + { 0x1e, KEY_PREVIOUS }, /* Replay |< */ 75 + { 0x1d, KEY_NEXT }, /* Skip >| */ 76 76 77 - { 0x0b, KEY_CAMERA }, // Capture 78 - { 0x0f, KEY_LANGUAGE }, // SAP 79 - { 0x18, KEY_MODE }, // PIP 80 - { 0x12, KEY_ZOOM }, // Full screen, 77 + { 0x0b, KEY_CAMERA }, /* Capture */ 78 + { 0x0f, KEY_LANGUAGE }, /* SAP */ 79 + { 0x18, KEY_MODE }, /* PIP */ 80 + { 0x12, KEY_ZOOM }, /* Full screen */ 81 81 { 0x1c, KEY_SUBTITLE }, 82 82 { 0x2f, KEY_MUTE }, 83 - { 0x16, KEY_F20 }, // L/R, 84 - { 0x38, KEY_F21 }, // Hibernate, 83 + { 0x16, KEY_F20 }, /* L/R */ 84 + { 0x38, KEY_F21 }, /* Hibernate */ 85 85 86 - { 0x37, KEY_SWITCHVIDEOMODE }, // A/V 87 - { 0x31, KEY_AGAIN }, // Recall, 88 - { 0x1a, KEY_KPPLUS }, // Zoom+, 89 - { 0x19, KEY_KPMINUS }, // Zoom-, 86 + { 0x37, KEY_SWITCHVIDEOMODE }, /* A/V */ 87 + { 0x31, KEY_AGAIN }, /* Recall */ 88 + { 0x1a, KEY_KPPLUS }, /* Zoom+ */ 89 + { 0x19, KEY_KPMINUS }, /* Zoom- */ 90 90 { 0x27, KEY_RED }, 91 91 { 0x0C, KEY_GREEN }, 92 92 { 0x01, KEY_YELLOW },
+1 -1
drivers/media/dvb/mantis/mantis_reg.h
··· 29 29 #define MANTIS_INT_RISCEN (0x01 << 27) 30 30 #define MANTIS_INT_I2CRACK (0x01 << 26) 31 31 32 - //#define MANTIS_INT_GPIF (0xff << 12) 32 + /* #define MANTIS_INT_GPIF (0xff << 12) */ 33 33 34 34 #define MANTIS_INT_PCMCIA7 (0x01 << 19) 35 35 #define MANTIS_INT_PCMCIA6 (0x01 << 18)
+6 -6
drivers/media/dvb/mantis/mantis_vp1033.c
··· 93 93 u32 div; 94 94 95 95 96 - struct i2c_msg msg = {.addr = 0x61, .flags = 0, .buf = buf, .len = sizeof (buf) }; 96 + struct i2c_msg msg = {.addr = 0x61, .flags = 0, .buf = buf, .len = sizeof(buf)}; 97 97 98 98 div = params->frequency / 250; 99 99 ··· 140 140 aclk = 0xb4; 141 141 bclk = 0x51; 142 142 } 143 - stv0299_writereg (fe, 0x13, aclk); 144 - stv0299_writereg (fe, 0x14, bclk); 143 + stv0299_writereg(fe, 0x13, aclk); 144 + stv0299_writereg(fe, 0x14, bclk); 145 145 146 - stv0299_writereg (fe, 0x1f, (ratio >> 16) & 0xff); 147 - stv0299_writereg (fe, 0x20, (ratio >> 8) & 0xff); 148 - stv0299_writereg (fe, 0x21, (ratio ) & 0xf0); 146 + stv0299_writereg(fe, 0x1f, (ratio >> 16) & 0xff); 147 + stv0299_writereg(fe, 0x20, (ratio >> 8) & 0xff); 148 + stv0299_writereg(fe, 0x21, ratio & 0xf0); 149 149 150 150 return 0; 151 151 }
+1 -1
drivers/media/dvb/mantis/mantis_vp1034.c
··· 62 62 dprintk(MANTIS_ERROR, 1, "Frontend (dummy) POWERDOWN"); 63 63 break; 64 64 default: 65 - dprintk(MANTIS_ERROR, 1, "Invalid = (%d)", (u32 ) voltage); 65 + dprintk(MANTIS_ERROR, 1, "Invalid = (%d)", (u32) voltage); 66 66 return -EINVAL; 67 67 } 68 68 mmwrite(0x00, MANTIS_GPIF_DOUT);
+4 -5
drivers/media/dvb/mantis/mantis_vp1041.c
··· 44 44 45 45 static const struct stb0899_s1_reg vp1041_stb0899_s1_init_1[] = { 46 46 47 - // 0x0000000b , /* SYSREG */ 47 + /* 0x0000000b, *//* SYSREG */ 48 48 { STB0899_DEV_ID , 0x30 }, 49 49 { STB0899_DISCNTRL1 , 0x32 }, 50 50 { STB0899_DISCNTRL2 , 0x80 }, ··· 55 55 { STB0899_DISSTATUS , 0x20 }, 56 56 { STB0899_DISF22 , 0x99 }, 57 57 { STB0899_DISF22RX , 0xa8 }, 58 - //SYSREG ? 58 + /* SYSREG ? */ 59 59 { STB0899_ACRPRESC , 0x11 }, 60 60 { STB0899_ACRDIV1 , 0x0a }, 61 61 { STB0899_ACRDIV2 , 0x05 }, ··· 323 323 vp1041_stb0899_config.demod_address); 324 324 325 325 if (stb6100_attach(mantis->fe, &vp1041_stb6100_config, adapter)) { 326 - if (!lnbp21_attach(mantis->fe, adapter, 0, 0)) { 327 - printk("%s: No LNBP21 found!\n", __func__); 328 - } 326 + if (!lnbp21_attach(mantis->fe, adapter, 0, 0)) 327 + dprintk(MANTIS_ERROR, 1, "No LNBP21 found!"); 329 328 } 330 329 } else { 331 330 return -EREMOTEIO;
+1 -1
drivers/media/dvb/mantis/mantis_vp2033.c
··· 71 71 struct i2c_adapter *adapter = &mantis->adapter; 72 72 73 73 u8 buf[6]; 74 - struct i2c_msg msg = {.addr = 0x60, .flags = 0, .buf = buf, .len = sizeof (buf) }; 74 + struct i2c_msg msg = {.addr = 0x60, .flags = 0, .buf = buf, .len = sizeof(buf)}; 75 75 int i; 76 76 77 77 #define CU1216_IF 36125000
+1 -1
drivers/media/dvb/mantis/mantis_vp2040.c
··· 53 53 struct i2c_adapter *adapter = &mantis->adapter; 54 54 55 55 u8 buf[6]; 56 - struct i2c_msg msg = {.addr = 0x60,.flags = 0,.buf = buf,.len = sizeof (buf) }; 56 + struct i2c_msg msg = {.addr = 0x60, .flags = 0, .buf = buf, .len = sizeof(buf)}; 57 57 int i; 58 58 59 59 #define CU1216_IF 36125000