Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

iio: temperature: hid-sensor: Convert to platform remove callback returning void

The .remove() callback for a platform driver returns an int which makes
many driver authors wrongly assume it's possible to do error handling by
returning an error code. However the value returned is ignored (apart
from emitting a warning) and this typically results in resource leaks.
To improve here there is a quest to make the remove callback return
void. In the first step of this quest all drivers are converted to
.remove_new() which already returns void. Eventually after all drivers
are converted, .remove_new() will be renamed to .remove().

Trivially convert this driver from always returning zero in the remove
callback to the void returning variant.

Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Link: https://lore.kernel.org/r/20230919174931.1417681-48-u.kleine-koenig@pengutronix.de
Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>

authored by

Uwe Kleine-König and committed by
Jonathan Cameron
f5589173 4abfc97d

+2 -4
+2 -4
drivers/iio/temperature/hid-sensor-temperature.c
··· 257 257 } 258 258 259 259 /* Function to deinitialize the processing for usage id */ 260 - static int hid_temperature_remove(struct platform_device *pdev) 260 + static void hid_temperature_remove(struct platform_device *pdev) 261 261 { 262 262 struct hid_sensor_hub_device *hsdev = dev_get_platdata(&pdev->dev); 263 263 struct iio_dev *indio_dev = platform_get_drvdata(pdev); ··· 265 265 266 266 sensor_hub_remove_callback(hsdev, HID_USAGE_SENSOR_TEMPERATURE); 267 267 hid_sensor_remove_trigger(indio_dev, &temp_st->common_attributes); 268 - 269 - return 0; 270 268 } 271 269 272 270 static const struct platform_device_id hid_temperature_ids[] = { ··· 283 285 .pm = &hid_sensor_pm_ops, 284 286 }, 285 287 .probe = hid_temperature_probe, 286 - .remove = hid_temperature_remove, 288 + .remove_new = hid_temperature_remove, 287 289 }; 288 290 module_platform_driver(hid_temperature_platform_driver); 289 291