Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

perf test: Don't signal all processes on system when interrupting tests

This signal handler loops over all tests on ctrl-C, but it's active
while the test list is being constructed. process.pid is 0, then -1,
then finally set to the child pid on fork. If the Ctrl-C is received
during this point a kill(-1, SIGINT) can be sent which affects all
processes.

Make sure the child has forked first before forwarding the signal. This
can be reproduced with ctrl-C immediately after launching perf test
which terminates the ssh connection.

Fixes: 553d5efeb341 ("perf test: Add a signal handler to kill forked child processes")
Signed-off-by: James Clark <james.clark@linaro.org>
Reviewed-by: Ian Rogers <irogers@google.com>
Link: https://lore.kernel.org/r/20241129151948.3199732-1-james.clark@linaro.org
Signed-off-by: Namhyung Kim <namhyung@kernel.org>

authored by

James Clark and committed by
Namhyung Kim
f54cd8f4 23c44f6c

+1 -1
+1 -1
tools/perf/tests/builtin-test.c
··· 508 508 for (size_t x = 0; x < num_tests; x++) { 509 509 struct child_test *child_test = child_tests[x]; 510 510 511 - if (!child_test) 511 + if (!child_test || child_test->process.pid <= 0) 512 512 continue; 513 513 514 514 pr_debug3("Killing %d pid %d\n",