Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

xfs: zero initialize highstale and lowstale in xfs_dir2_leaf_addname

Smatch complains about the following:

fs/xfs/libxfs/xfs_dir2_leaf.c:848 xfs_dir2_leaf_addname() error:
uninitialized symbol 'lowstale'.

fs/xfs/libxfs/xfs_dir2_leaf.c:849 xfs_dir2_leaf_addname() error:
uninitialized symbol 'highstale'.

I don't think there's any incorrect behavior associated with the
uninitialized variable, but as the author of the previous zero-init
patch points out, it's best not to be passing around pointers to
uninitialized stack areas.

Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>
Reviewed-by: Nathan Chancellor <natechancellor@gmail.com>
Reviewed-by: Allison Henderson <allison.henderson@oracle.com>
Reviewed-by: Bill O'Donnell <billodo@redhat.com>

+2 -2
+2 -2
fs/xfs/libxfs/xfs_dir2_leaf.c
··· 574 574 xfs_dir2_data_unused_t *dup; /* data unused entry */ 575 575 int error; /* error return value */ 576 576 int grown; /* allocated new data block */ 577 - int highstale; /* index of next stale leaf */ 577 + int highstale = 0; /* index of next stale leaf */ 578 578 int i; /* temporary, index */ 579 579 int index; /* leaf table position */ 580 580 struct xfs_buf *lbp; /* leaf's buffer */ ··· 583 583 xfs_dir2_leaf_entry_t *lep; /* leaf entry table pointer */ 584 584 int lfloglow; /* low leaf logging index */ 585 585 int lfloghigh; /* high leaf logging index */ 586 - int lowstale; /* index of prev stale leaf */ 586 + int lowstale = 0; /* index of prev stale leaf */ 587 587 xfs_dir2_leaf_tail_t *ltp; /* leaf tail pointer */ 588 588 int needbytes; /* leaf block bytes needed */ 589 589 int needlog; /* need to log data header */