Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

rtc: sh: Convert to platform remove callback returning void

The .remove() callback for a platform driver returns an int which makes
many driver authors wrongly assume it's possible to do error handling by
returning an error code. However the value returned is ignored (apart
from emitting a warning) and this typically results in resource leaks.

To improve here there is a quest to make the remove callback return
void. In the first step of this quest all drivers are converted to
.remove_new(), which already returns void. Eventually after all drivers
are converted, .remove_new() will be renamed to .remove().

Trivially convert this driver from always returning zero in the remove
callback to the void returning variant.

Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Link: https://lore.kernel.org/r/20231002080529.2535610-13-u.kleine-koenig@pengutronix.de
Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com>

authored by

Uwe Kleine-König and committed by
Alexandre Belloni
f4d571b3 e288cfe8

+2 -4
+2 -4
drivers/rtc/rtc-sh.c
··· 620 620 return ret; 621 621 } 622 622 623 - static int __exit sh_rtc_remove(struct platform_device *pdev) 623 + static void __exit sh_rtc_remove(struct platform_device *pdev) 624 624 { 625 625 struct sh_rtc *rtc = platform_get_drvdata(pdev); 626 626 ··· 628 628 sh_rtc_setcie(&pdev->dev, 0); 629 629 630 630 clk_disable(rtc->clk); 631 - 632 - return 0; 633 631 } 634 632 635 633 static void sh_rtc_set_irq_wake(struct device *dev, int enabled) ··· 678 680 .pm = &sh_rtc_pm_ops, 679 681 .of_match_table = sh_rtc_of_match, 680 682 }, 681 - .remove = __exit_p(sh_rtc_remove), 683 + .remove_new = __exit_p(sh_rtc_remove), 682 684 }; 683 685 684 686 module_platform_driver_probe(sh_rtc_platform_driver, sh_rtc_probe);