switch debugfs to umode_t · tjh.dev/kernel@f4ae40a

tjh.dev / kernel

fork atom

Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git

kernel os linux

fork atom

switch debugfs to umode_t

Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>

Al Viro 14 years ago f4ae40a6 48176a97

+82 -82

25 changed files

expand all collapse all

Documentation

filesystems

debugfs.txt

arch

arm

mach-msm

smd_debug.c

s390

include

asm

debug.h

kernel

debug.c

x86

xen

debugfs.c

debugfs.h

drivers

acpi

ec_sys.c

mmc

card

mmc_test.c

net

ethernet

chelsio

cxgb4vf

cxgb4vf_main.c

wireless

ath

carl9170

debug.c

libertas

debugfs.c

s390

block

dasd.c

scsi

bfa

bfad_debugfs.c

debugfs

file.c

inode.c

ocfs2

cluster

netdebug.c

include

linux

debugfs.h

relay.h

kernel

relay.c

trace

blktrace.c

trace.c

trace.h

lib

fault-inject.c

failslab.c

page_alloc.c

+12 -12

Documentation/filesystems/debugfs.txt

reviewed

··· 35 35 36 36 The most general way to create a file within a debugfs directory is with: 37 37 38 38 - struct dentry *debugfs_create_file(const char *name, mode_t mode, 38 38 + struct dentry *debugfs_create_file(const char *name, umode_t mode, 39 39 struct dentry *parent, void *data, 40 40 const struct file_operations *fops); 41 41 ··· 53 53 for simple situations. Files containing a single integer value can be 54 54 created with any of: 55 55 56 56 - struct dentry *debugfs_create_u8(const char *name, mode_t mode, 56 56 + struct dentry *debugfs_create_u8(const char *name, umode_t mode, 57 57 struct dentry *parent, u8 *value); 58 58 - struct dentry *debugfs_create_u16(const char *name, mode_t mode, 58 58 + struct dentry *debugfs_create_u16(const char *name, umode_t mode, 59 59 struct dentry *parent, u16 *value); 60 60 - struct dentry *debugfs_create_u32(const char *name, mode_t mode, 60 60 + struct dentry *debugfs_create_u32(const char *name, umode_t mode, 61 61 struct dentry *parent, u32 *value); 62 62 - struct dentry *debugfs_create_u64(const char *name, mode_t mode, 62 62 + struct dentry *debugfs_create_u64(const char *name, umode_t mode, 63 63 struct dentry *parent, u64 *value); 64 64 65 65 These files support both reading and writing the given value; if a specific ··· 67 67 values in these files are in decimal; if hexadecimal is more appropriate, 68 68 the following functions can be used instead: 69 69 70 70 - struct dentry *debugfs_create_x8(const char *name, mode_t mode, 70 70 + struct dentry *debugfs_create_x8(const char *name, umode_t mode, 71 71 struct dentry *parent, u8 *value); 72 72 - struct dentry *debugfs_create_x16(const char *name, mode_t mode, 72 72 + struct dentry *debugfs_create_x16(const char *name, umode_t mode, 73 73 struct dentry *parent, u16 *value); 74 74 - struct dentry *debugfs_create_x32(const char *name, mode_t mode, 74 74 + struct dentry *debugfs_create_x32(const char *name, umode_t mode, 75 75 struct dentry *parent, u32 *value); 76 76 - struct dentry *debugfs_create_x64(const char *name, mode_t mode, 76 76 + struct dentry *debugfs_create_x64(const char *name, umode_t mode, 77 77 struct dentry *parent, u64 *value); 78 78 79 79 These functions are useful as long as the developer knows the size of the ··· 81 81 architectures, though, complicating the situation somewhat. There is a 82 82 function meant to help out in one special case: 83 83 84 84 - struct dentry *debugfs_create_size_t(const char *name, mode_t mode, 84 84 + struct dentry *debugfs_create_size_t(const char *name, umode_t mode, 85 85 struct dentry *parent, 86 86 size_t *value); 87 87 ··· 90 90 91 91 Boolean values can be placed in debugfs with: 92 92 93 93 - struct dentry *debugfs_create_bool(const char *name, mode_t mode, 93 93 + struct dentry *debugfs_create_bool(const char *name, umode_t mode, 94 94 struct dentry *parent, u32 *value); 95 95 96 96 A read on the resulting file will yield either Y (for non-zero values) or ··· 104 104 unsigned long size; 105 105 }; 106 106 107 107 - struct dentry *debugfs_create_blob(const char *name, mode_t mode, 107 107 + struct dentry *debugfs_create_blob(const char *name, umode_t mode, 108 108 struct dentry *parent, 109 109 struct debugfs_blob_wrapper *blob); 110 110

+1 -1

arch/arm/mach-msm/smd_debug.c

reviewed

··· 215 215 .llseek = default_llseek, 216 216 }; 217 217 218 218 - static void debug_create(const char *name, mode_t mode, 218 218 + static void debug_create(const char *name, umode_t mode, 219 219 struct dentry *dent, 220 220 int (*fill)(char *buf, int max)) 221 221 {

+2 -2

arch/s390/include/asm/debug.h

reviewed

··· 73 73 struct dentry* debugfs_entries[DEBUG_MAX_VIEWS]; 74 74 struct debug_view* views[DEBUG_MAX_VIEWS]; 75 75 char name[DEBUG_MAX_NAME_LEN]; 76 76 - mode_t mode; 76 76 + umode_t mode; 77 77 } debug_info_t; 78 78 79 79 typedef int (debug_header_proc_t) (debug_info_t* id, ··· 124 124 int buf_size); 125 125 126 126 debug_info_t *debug_register_mode(const char *name, int pages, int nr_areas, 127 127 - int buf_size, mode_t mode, uid_t uid, 127 127 + int buf_size, umode_t mode, uid_t uid, 128 128 gid_t gid); 129 129 130 130 void debug_unregister(debug_info_t* id);

+4 -4

arch/s390/kernel/debug.c

reviewed

··· 74 74 static int debug_open(struct inode *inode, struct file *file); 75 75 static int debug_close(struct inode *inode, struct file *file); 76 76 static debug_info_t *debug_info_create(const char *name, int pages_per_area, 77 77 - int nr_areas, int buf_size, mode_t mode); 77 77 + int nr_areas, int buf_size, umode_t mode); 78 78 static void debug_info_get(debug_info_t *); 79 79 static void debug_info_put(debug_info_t *); 80 80 static int debug_prolog_level_fn(debug_info_t * id, ··· 330 330 331 331 static debug_info_t* 332 332 debug_info_create(const char *name, int pages_per_area, int nr_areas, 333 333 - int buf_size, mode_t mode) 333 333 + int buf_size, umode_t mode) 334 334 { 335 335 debug_info_t* rc; 336 336 ··· 688 688 */ 689 689 690 690 debug_info_t *debug_register_mode(const char *name, int pages_per_area, 691 691 - int nr_areas, int buf_size, mode_t mode, 691 691 + int nr_areas, int buf_size, umode_t mode, 692 692 uid_t uid, gid_t gid) 693 693 { 694 694 debug_info_t *rc = NULL; ··· 1090 1090 int rc = 0; 1091 1091 int i; 1092 1092 unsigned long flags; 1093 1093 - mode_t mode; 1093 1093 + umode_t mode; 1094 1094 struct dentry *pde; 1095 1095 1096 1096 if (!id)

+1 -1

arch/x86/xen/debugfs.c

reviewed

··· 109 109 .llseek = no_llseek, 110 110 }; 111 111 112 112 - struct dentry *xen_debugfs_create_u32_array(const char *name, mode_t mode, 112 112 + struct dentry *xen_debugfs_create_u32_array(const char *name, umode_t mode, 113 113 struct dentry *parent, 114 114 u32 *array, unsigned elements) 115 115 {

+1 -1

arch/x86/xen/debugfs.h

reviewed

··· 3 3 4 4 struct dentry * __init xen_init_debugfs(void); 5 5 6 6 - struct dentry *xen_debugfs_create_u32_array(const char *name, mode_t mode, 6 6 + struct dentry *xen_debugfs_create_u32_array(const char *name, umode_t mode, 7 7 struct dentry *parent, 8 8 u32 *array, unsigned elements); 9 9

+1 -1

drivers/acpi/ec_sys.c

reviewed

··· 105 105 { 106 106 struct dentry *dev_dir; 107 107 char name[64]; 108 108 - mode_t mode = 0400; 108 108 + umode_t mode = 0400; 109 109 110 110 if (ec_device_count == 0) { 111 111 acpi_ec_debugfs_dir = debugfs_create_dir("ec", NULL);

+1 -1

drivers/mmc/card/mmc_test.c

reviewed

··· 2949 2949 } 2950 2950 2951 2951 static int __mmc_test_register_dbgfs_file(struct mmc_card *card, 2952 2952 - const char *name, mode_t mode, const struct file_operations *fops) 2952 2952 + const char *name, umode_t mode, const struct file_operations *fops) 2953 2953 { 2954 2954 struct dentry *file = NULL; 2955 2955 struct mmc_test_dbgfs_file *df;

+1 -1

drivers/net/ethernet/chelsio/cxgb4vf/cxgb4vf_main.c

reviewed

··· 2000 2000 */ 2001 2001 struct cxgb4vf_debugfs_entry { 2002 2002 const char *name; /* name of debugfs node */ 2003 2003 - mode_t mode; /* file system mode */ 2003 2003 + umode_t mode; /* file system mode */ 2004 2004 const struct file_operations *fops; 2005 2005 }; 2006 2006

+1 -1

drivers/net/wireless/ath/carl9170/debug.c

reviewed

··· 56 56 57 57 struct carl9170_debugfs_fops { 58 58 unsigned int read_bufsize; 59 59 - mode_t attr; 59 59 + umode_t attr; 60 60 char *(*read)(struct ar9170 *ar, char *buf, size_t bufsize, 61 61 ssize_t *len); 62 62 ssize_t (*write)(struct ar9170 *aru, const char *buf, size_t size);

+1 -1

drivers/net/wireless/libertas/debugfs.c

reviewed

··· 704 704 705 705 struct lbs_debugfs_files { 706 706 const char *name; 707 707 - int perm; 707 707 + umode_t perm; 708 708 struct file_operations fops; 709 709 }; 710 710

+2 -2

drivers/s390/block/dasd.c

reviewed

··· 1073 1073 static void dasd_profile_init(struct dasd_profile *profile, 1074 1074 struct dentry *base_dentry) 1075 1075 { 1076 1076 - mode_t mode; 1076 1076 + umode_t mode; 1077 1077 struct dentry *pde; 1078 1078 1079 1079 if (!base_dentry) ··· 1112 1112 1113 1113 static void dasd_statistics_createroot(void) 1114 1114 { 1115 1115 - mode_t mode; 1115 1115 + umode_t mode; 1116 1116 struct dentry *pde; 1117 1117 1118 1118 dasd_debugfs_root_entry = NULL;

+1 -1

drivers/scsi/bfa/bfad_debugfs.c

reviewed

··· 472 472 473 473 struct bfad_debugfs_entry { 474 474 const char *name; 475 475 - mode_t mode; 475 475 + umode_t mode; 476 476 const struct file_operations *fops; 477 477 }; 478 478

+11 -11

fs/debugfs/file.c

reviewed

··· 95 95 * %NULL or !%NULL instead as to eliminate the need for #ifdef in the calling 96 96 * code. 97 97 */ 98 98 - struct dentry *debugfs_create_u8(const char *name, mode_t mode, 98 98 + struct dentry *debugfs_create_u8(const char *name, umode_t mode, 99 99 struct dentry *parent, u8 *value) 100 100 { 101 101 /* if there are no write bits set, make read only */ ··· 147 147 * %NULL or !%NULL instead as to eliminate the need for #ifdef in the calling 148 148 * code. 149 149 */ 150 150 - struct dentry *debugfs_create_u16(const char *name, mode_t mode, 150 150 + struct dentry *debugfs_create_u16(const char *name, umode_t mode, 151 151 struct dentry *parent, u16 *value) 152 152 { 153 153 /* if there are no write bits set, make read only */ ··· 199 199 * %NULL or !%NULL instead as to eliminate the need for #ifdef in the calling 200 200 * code. 201 201 */ 202 202 - struct dentry *debugfs_create_u32(const char *name, mode_t mode, 202 202 + struct dentry *debugfs_create_u32(const char *name, umode_t mode, 203 203 struct dentry *parent, u32 *value) 204 204 { 205 205 /* if there are no write bits set, make read only */ ··· 252 252 * %NULL or !%NULL instead as to eliminate the need for #ifdef in the calling 253 253 * code. 254 254 */ 255 255 - struct dentry *debugfs_create_u64(const char *name, mode_t mode, 255 255 + struct dentry *debugfs_create_u64(const char *name, umode_t mode, 256 256 struct dentry *parent, u64 *value) 257 257 { 258 258 /* if there are no write bits set, make read only */ ··· 298 298 * @value: a pointer to the variable that the file should read to and write 299 299 * from. 300 300 */ 301 301 - struct dentry *debugfs_create_x8(const char *name, mode_t mode, 301 301 + struct dentry *debugfs_create_x8(const char *name, umode_t mode, 302 302 struct dentry *parent, u8 *value) 303 303 { 304 304 /* if there are no write bits set, make read only */ ··· 322 322 * @value: a pointer to the variable that the file should read to and write 323 323 * from. 324 324 */ 325 325 - struct dentry *debugfs_create_x16(const char *name, mode_t mode, 325 325 + struct dentry *debugfs_create_x16(const char *name, umode_t mode, 326 326 struct dentry *parent, u16 *value) 327 327 { 328 328 /* if there are no write bits set, make read only */ ··· 346 346 * @value: a pointer to the variable that the file should read to and write 347 347 * from. 348 348 */ 349 349 - struct dentry *debugfs_create_x32(const char *name, mode_t mode, 349 349 + struct dentry *debugfs_create_x32(const char *name, umode_t mode, 350 350 struct dentry *parent, u32 *value) 351 351 { 352 352 /* if there are no write bits set, make read only */ ··· 370 370 * @value: a pointer to the variable that the file should read to and write 371 371 * from. 372 372 */ 373 373 - struct dentry *debugfs_create_x64(const char *name, mode_t mode, 373 373 + struct dentry *debugfs_create_x64(const char *name, umode_t mode, 374 374 struct dentry *parent, u64 *value) 375 375 { 376 376 return debugfs_create_file(name, mode, parent, value, &fops_x64); ··· 401 401 * @value: a pointer to the variable that the file should read to and write 402 402 * from. 403 403 */ 404 404 - struct dentry *debugfs_create_size_t(const char *name, mode_t mode, 404 404 + struct dentry *debugfs_create_size_t(const char *name, umode_t mode, 405 405 struct dentry *parent, size_t *value) 406 406 { 407 407 return debugfs_create_file(name, mode, parent, value, &fops_size_t); ··· 473 473 * %NULL or !%NULL instead as to eliminate the need for #ifdef in the calling 474 474 * code. 475 475 */ 476 476 - struct dentry *debugfs_create_bool(const char *name, mode_t mode, 476 476 + struct dentry *debugfs_create_bool(const char *name, umode_t mode, 477 477 struct dentry *parent, u32 *value) 478 478 { 479 479 return debugfs_create_file(name, mode, parent, value, &fops_bool); ··· 518 518 * %NULL or !%NULL instead as to eliminate the need for #ifdef in the calling 519 519 * code. 520 520 */ 521 521 - struct dentry *debugfs_create_blob(const char *name, mode_t mode, 521 521 + struct dentry *debugfs_create_blob(const char *name, umode_t mode, 522 522 struct dentry *parent, 523 523 struct debugfs_blob_wrapper *blob) 524 524 {

+7 -7

fs/debugfs/inode.c

reviewed

··· 30 30 static int debugfs_mount_count; 31 31 static bool debugfs_registered; 32 32 33 33 - static struct inode *debugfs_get_inode(struct super_block *sb, int mode, dev_t dev, 33 33 + static struct inode *debugfs_get_inode(struct super_block *sb, umode_t mode, dev_t dev, 34 34 void *data, const struct file_operations *fops) 35 35 36 36 { ··· 69 69 70 70 /* SMP-safe */ 71 71 static int debugfs_mknod(struct inode *dir, struct dentry *dentry, 72 72 - int mode, dev_t dev, void *data, 72 72 + umode_t mode, dev_t dev, void *data, 73 73 const struct file_operations *fops) 74 74 { 75 75 struct inode *inode; ··· 87 87 return error; 88 88 } 89 89 90 90 - static int debugfs_mkdir(struct inode *dir, struct dentry *dentry, int mode, 90 90 + static int debugfs_mkdir(struct inode *dir, struct dentry *dentry, umode_t mode, 91 91 void *data, const struct file_operations *fops) 92 92 { 93 93 int res; ··· 101 101 return res; 102 102 } 103 103 104 104 - static int debugfs_link(struct inode *dir, struct dentry *dentry, int mode, 104 104 + static int debugfs_link(struct inode *dir, struct dentry *dentry, umode_t mode, 105 105 void *data, const struct file_operations *fops) 106 106 { 107 107 mode = (mode & S_IALLUGO) | S_IFLNK; 108 108 return debugfs_mknod(dir, dentry, mode, 0, data, fops); 109 109 } 110 110 111 111 - static int debugfs_create(struct inode *dir, struct dentry *dentry, int mode, 111 111 + static int debugfs_create(struct inode *dir, struct dentry *dentry, umode_t mode, 112 112 void *data, const struct file_operations *fops) 113 113 { 114 114 int res; ··· 146 146 .kill_sb = kill_litter_super, 147 147 }; 148 148 149 149 - static int debugfs_create_by_name(const char *name, mode_t mode, 149 149 + static int debugfs_create_by_name(const char *name, umode_t mode, 150 150 struct dentry *parent, 151 151 struct dentry **dentry, 152 152 void *data, ··· 214 214 * If debugfs is not enabled in the kernel, the value -%ENODEV will be 215 215 * returned. 216 216 */ 217 217 - struct dentry *debugfs_create_file(const char *name, mode_t mode, 217 217 + struct dentry *debugfs_create_file(const char *name, umode_t mode, 218 218 struct dentry *parent, void *data, 219 219 const struct file_operations *fops) 220 220 {

+1 -1

fs/ocfs2/cluster/netdebug.c

reviewed

··· 553 553 554 554 int o2net_debugfs_init(void) 555 555 { 556 556 - mode_t mode = S_IFREG|S_IRUSR; 556 556 + umode_t mode = S_IFREG|S_IRUSR; 557 557 558 558 o2net_dentry = debugfs_create_dir(O2NET_DEBUG_DIR, NULL); 559 559 if (o2net_dentry)

+23 -23

include/linux/debugfs.h

reviewed

··· 34 34 extern const struct file_operations debugfs_file_operations; 35 35 extern const struct inode_operations debugfs_link_operations; 36 36 37 37 - struct dentry *debugfs_create_file(const char *name, mode_t mode, 37 37 + struct dentry *debugfs_create_file(const char *name, umode_t mode, 38 38 struct dentry *parent, void *data, 39 39 const struct file_operations *fops); 40 40 ··· 49 49 struct dentry *debugfs_rename(struct dentry *old_dir, struct dentry *old_dentry, 50 50 struct dentry *new_dir, const char *new_name); 51 51 52 52 - struct dentry *debugfs_create_u8(const char *name, mode_t mode, 52 52 + struct dentry *debugfs_create_u8(const char *name, umode_t mode, 53 53 struct dentry *parent, u8 *value); 54 54 - struct dentry *debugfs_create_u16(const char *name, mode_t mode, 54 54 + struct dentry *debugfs_create_u16(const char *name, umode_t mode, 55 55 struct dentry *parent, u16 *value); 56 56 - struct dentry *debugfs_create_u32(const char *name, mode_t mode, 56 56 + struct dentry *debugfs_create_u32(const char *name, umode_t mode, 57 57 struct dentry *parent, u32 *value); 58 58 - struct dentry *debugfs_create_u64(const char *name, mode_t mode, 58 58 + struct dentry *debugfs_create_u64(const char *name, umode_t mode, 59 59 struct dentry *parent, u64 *value); 60 60 - struct dentry *debugfs_create_x8(const char *name, mode_t mode, 60 60 + struct dentry *debugfs_create_x8(const char *name, umode_t mode, 61 61 struct dentry *parent, u8 *value); 62 62 - struct dentry *debugfs_create_x16(const char *name, mode_t mode, 62 62 + struct dentry *debugfs_create_x16(const char *name, umode_t mode, 63 63 struct dentry *parent, u16 *value); 64 64 - struct dentry *debugfs_create_x32(const char *name, mode_t mode, 64 64 + struct dentry *debugfs_create_x32(const char *name, umode_t mode, 65 65 struct dentry *parent, u32 *value); 66 66 - struct dentry *debugfs_create_x64(const char *name, mode_t mode, 66 66 + struct dentry *debugfs_create_x64(const char *name, umode_t mode, 67 67 struct dentry *parent, u64 *value); 68 68 - struct dentry *debugfs_create_size_t(const char *name, mode_t mode, 68 68 + struct dentry *debugfs_create_size_t(const char *name, umode_t mode, 69 69 struct dentry *parent, size_t *value); 70 70 - struct dentry *debugfs_create_bool(const char *name, mode_t mode, 70 70 + struct dentry *debugfs_create_bool(const char *name, umode_t mode, 71 71 struct dentry *parent, u32 *value); 72 72 73 73 - struct dentry *debugfs_create_blob(const char *name, mode_t mode, 73 73 + struct dentry *debugfs_create_blob(const char *name, umode_t mode, 74 74 struct dentry *parent, 75 75 struct debugfs_blob_wrapper *blob); 76 76 ··· 86 86 * want to duplicate the design decision mistakes of procfs and devfs again. 87 87 */ 88 88 89 89 - static inline struct dentry *debugfs_create_file(const char *name, mode_t mode, 89 89 + static inline struct dentry *debugfs_create_file(const char *name, umode_t mode, 90 90 struct dentry *parent, void *data, 91 91 const struct file_operations *fops) 92 92 { ··· 118 118 return ERR_PTR(-ENODEV); 119 119 } 120 120 121 121 - static inline struct dentry *debugfs_create_u8(const char *name, mode_t mode, 121 121 + static inline struct dentry *debugfs_create_u8(const char *name, umode_t mode, 122 122 struct dentry *parent, 123 123 u8 *value) 124 124 { 125 125 return ERR_PTR(-ENODEV); 126 126 } 127 127 128 128 - static inline struct dentry *debugfs_create_u16(const char *name, mode_t mode, 128 128 + static inline struct dentry *debugfs_create_u16(const char *name, umode_t mode, 129 129 struct dentry *parent, 130 130 u16 *value) 131 131 { 132 132 return ERR_PTR(-ENODEV); 133 133 } 134 134 135 135 - static inline struct dentry *debugfs_create_u32(const char *name, mode_t mode, 135 135 + static inline struct dentry *debugfs_create_u32(const char *name, umode_t mode, 136 136 struct dentry *parent, 137 137 u32 *value) 138 138 { 139 139 return ERR_PTR(-ENODEV); 140 140 } 141 141 142 142 - static inline struct dentry *debugfs_create_u64(const char *name, mode_t mode, 142 142 + static inline struct dentry *debugfs_create_u64(const char *name, umode_t mode, 143 143 struct dentry *parent, 144 144 u64 *value) 145 145 { 146 146 return ERR_PTR(-ENODEV); 147 147 } 148 148 149 149 - static inline struct dentry *debugfs_create_x8(const char *name, mode_t mode, 149 149 + static inline struct dentry *debugfs_create_x8(const char *name, umode_t mode, 150 150 struct dentry *parent, 151 151 u8 *value) 152 152 { 153 153 return ERR_PTR(-ENODEV); 154 154 } 155 155 156 156 - static inline struct dentry *debugfs_create_x16(const char *name, mode_t mode, 156 156 + static inline struct dentry *debugfs_create_x16(const char *name, umode_t mode, 157 157 struct dentry *parent, 158 158 u16 *value) 159 159 { 160 160 return ERR_PTR(-ENODEV); 161 161 } 162 162 163 163 - static inline struct dentry *debugfs_create_x32(const char *name, mode_t mode, 163 163 + static inline struct dentry *debugfs_create_x32(const char *name, umode_t mode, 164 164 struct dentry *parent, 165 165 u32 *value) 166 166 { 167 167 return ERR_PTR(-ENODEV); 168 168 } 169 169 170 170 - static inline struct dentry *debugfs_create_size_t(const char *name, mode_t mode, 170 170 + static inline struct dentry *debugfs_create_size_t(const char *name, umode_t mode, 171 171 struct dentry *parent, 172 172 size_t *value) 173 173 { 174 174 return ERR_PTR(-ENODEV); 175 175 } 176 176 177 177 - static inline struct dentry *debugfs_create_bool(const char *name, mode_t mode, 177 177 + static inline struct dentry *debugfs_create_bool(const char *name, umode_t mode, 178 178 struct dentry *parent, 179 179 u32 *value) 180 180 { 181 181 return ERR_PTR(-ENODEV); 182 182 } 183 183 184 184 - static inline struct dentry *debugfs_create_blob(const char *name, mode_t mode, 184 184 + static inline struct dentry *debugfs_create_blob(const char *name, umode_t mode, 185 185 struct dentry *parent, 186 186 struct debugfs_blob_wrapper *blob) 187 187 {

+1 -1

include/linux/relay.h

reviewed

··· 144 144 */ 145 145 struct dentry *(*create_buf_file)(const char *filename, 146 146 struct dentry *parent, 147 147 - int mode, 147 147 + umode_t mode, 148 148 struct rchan_buf *buf, 149 149 int *is_global); 150 150

+1 -1

kernel/relay.c

reviewed

··· 302 302 */ 303 303 static struct dentry *create_buf_file_default_callback(const char *filename, 304 304 struct dentry *parent, 305 305 - int mode, 305 305 + umode_t mode, 306 306 struct rchan_buf *buf, 307 307 int *is_global) 308 308 {

+1 -1

kernel/trace/blktrace.c

reviewed

··· 402 402 403 403 static struct dentry *blk_create_buf_file_callback(const char *filename, 404 404 struct dentry *parent, 405 405 - int mode, 405 405 + umode_t mode, 406 406 struct rchan_buf *buf, 407 407 int *is_global) 408 408 {

+1 -1

kernel/trace/trace.c

reviewed

··· 4385 4385 }; 4386 4386 4387 4387 struct dentry *trace_create_file(const char *name, 4388 4388 - mode_t mode, 4388 4388 + umode_t mode, 4389 4389 struct dentry *parent, 4390 4390 void *data, 4391 4391 const struct file_operations *fops)

+1 -1

kernel/trace/trace.h

reviewed

··· 312 312 void tracing_reset_current_online_cpus(void); 313 313 int tracing_open_generic(struct inode *inode, struct file *filp); 314 314 struct dentry *trace_create_file(const char *name, 315 315 - mode_t mode, 315 315 + umode_t mode, 316 316 struct dentry *parent, 317 317 void *data, 318 318 const struct file_operations *fops);

+4 -4

lib/fault-inject.c

reviewed

··· 149 149 150 150 DEFINE_SIMPLE_ATTRIBUTE(fops_ul, debugfs_ul_get, debugfs_ul_set, "%llu\n"); 151 151 152 152 - static struct dentry *debugfs_create_ul(const char *name, mode_t mode, 152 152 + static struct dentry *debugfs_create_ul(const char *name, umode_t mode, 153 153 struct dentry *parent, unsigned long *value) 154 154 { 155 155 return debugfs_create_file(name, mode, parent, value, &fops_ul); ··· 169 169 debugfs_stacktrace_depth_set, "%llu\n"); 170 170 171 171 static struct dentry *debugfs_create_stacktrace_depth( 172 172 - const char *name, mode_t mode, 172 172 + const char *name, umode_t mode, 173 173 struct dentry *parent, unsigned long *value) 174 174 { 175 175 return debugfs_create_file(name, mode, parent, value, ··· 193 193 DEFINE_SIMPLE_ATTRIBUTE(fops_atomic_t, debugfs_atomic_t_get, 194 194 debugfs_atomic_t_set, "%lld\n"); 195 195 196 196 - static struct dentry *debugfs_create_atomic_t(const char *name, mode_t mode, 196 196 + static struct dentry *debugfs_create_atomic_t(const char *name, umode_t mode, 197 197 struct dentry *parent, atomic_t *value) 198 198 { 199 199 return debugfs_create_file(name, mode, parent, value, &fops_atomic_t); ··· 202 202 struct dentry *fault_create_debugfs_attr(const char *name, 203 203 struct dentry *parent, struct fault_attr *attr) 204 204 { 205 205 - mode_t mode = S_IFREG | S_IRUSR | S_IWUSR; 205 205 + umode_t mode = S_IFREG | S_IRUSR | S_IWUSR; 206 206 struct dentry *dir; 207 207 208 208 dir = debugfs_create_dir(name, parent);

+1 -1

mm/failslab.c

reviewed

··· 35 35 static int __init failslab_debugfs_init(void) 36 36 { 37 37 struct dentry *dir; 38 38 - mode_t mode = S_IFREG | S_IRUSR | S_IWUSR; 38 38 + umode_t mode = S_IFREG | S_IRUSR | S_IWUSR; 39 39 40 40 dir = fault_create_debugfs_attr("failslab", NULL, &failslab.attr); 41 41 if (IS_ERR(dir))

+1 -1

mm/page_alloc.c

reviewed

··· 1408 1408 1409 1409 static int __init fail_page_alloc_debugfs(void) 1410 1410 { 1411 1411 - mode_t mode = S_IFREG | S_IRUSR | S_IWUSR; 1411 1411 + umode_t mode = S_IFREG | S_IRUSR | S_IWUSR; 1412 1412 struct dentry *dir; 1413 1413 1414 1414 dir = fault_create_debugfs_attr("fail_page_alloc", NULL,