Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

PCI: histb: Drop error data fabrication when config read fails

If config pci_ops.read() methods return failure, the PCI_OP_READ() and
PCI_USER_READ_CONFIG() wrappers use PCI_SET_ERROR_RESPONSE() to set the
data value, so there's no need to set it in the pci_ops.read() methods
themselves.

Drop the unnecessary data value fabrication when pci_ops.read() fails.

Link: https://lore.kernel.org/r/7da7ea760abc5f85cad6e9b0d3e59eebd93f50d3.1637243717.git.naveennaidu479@gmail.com
Signed-off-by: Naveen Naidu <naveennaidu479@gmail.com>
Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>

authored by

Naveen Naidu and committed by
Bjorn Helgaas
f4a44c1e 8ed2196a

+1 -3
+1 -3
drivers/pci/controller/dwc/pcie-histb.c
··· 127 127 { 128 128 struct dw_pcie *pci = to_dw_pcie_from_pp(bus->sysdata); 129 129 130 - if (PCI_SLOT(devfn)) { 131 - *val = ~0; 130 + if (PCI_SLOT(devfn)) 132 131 return PCIBIOS_DEVICE_NOT_FOUND; 133 - } 134 132 135 133 *val = dw_pcie_read_dbi(pci, where, size); 136 134 return PCIBIOS_SUCCESSFUL;