Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

drm/i2c: tda998x: Replace all non-returning strlcpy with strscpy

strlcpy() reads the entire source buffer first.
This read may exceed the destination size limit.
This is both inefficient and can lead to linear read
overflows if a source string is not NUL-terminated [1].
In an effort to remove strlcpy() completely [2], replace
strlcpy() here with strscpy().
No return values were used, so direct replacement is safe.

[1] https://www.kernel.org/doc/html/latest/process/deprecated.html#strlcpy
[2] https://github.com/KSPP/linux/issues/89

Signed-off-by: Azeem Shaikh <azeemshaikh38@gmail.com>
Reviewed-by: Kees Cook <keescook@chromium.org>
Signed-off-by: Kees Cook <keescook@chromium.org>
Link: https://lore.kernel.org/r/20230522155350.2337029-1-azeemshaikh38@gmail.com

authored by

Azeem Shaikh and committed by
Kees Cook
f4a0659f 83602576

+1 -1
+1 -1
drivers/gpu/drm/i2c/tda998x_drv.c
··· 1951 1951 * offset. 1952 1952 */ 1953 1953 memset(&cec_info, 0, sizeof(cec_info)); 1954 - strlcpy(cec_info.type, "tda9950", sizeof(cec_info.type)); 1954 + strscpy(cec_info.type, "tda9950", sizeof(cec_info.type)); 1955 1955 cec_info.addr = priv->cec_addr; 1956 1956 cec_info.platform_data = &priv->cec_glue; 1957 1957 cec_info.irq = client->irq;