Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

PCI: Constify label attribute_group structures

attribute_groups are not supposed to change at runtime. All functions
working with attribute_groups provided by <linux/sysfs.h> work with const
attribute_group. So mark the non-const structs as const.

File size before:
text data bss dec hex filename
930 320 0 1250 4e2 drivers/pci/pci-label.o

File size After adding 'const':
text data bss dec hex filename
1058 192 0 1250 4ca drivers/pci/pci-label.o

Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>

authored by

Arvind Yadav and committed by
Bjorn Helgaas
f4841285 e7ea9825

+2 -2
+2 -2
drivers/pci/pci-label.c
··· 123 123 NULL, 124 124 }; 125 125 126 - static struct attribute_group smbios_attr_group = { 126 + static const struct attribute_group smbios_attr_group = { 127 127 .attrs = smbios_attributes, 128 128 .is_visible = smbios_instance_string_exist, 129 129 }; ··· 260 260 NULL, 261 261 }; 262 262 263 - static struct attribute_group acpi_attr_group = { 263 + static const struct attribute_group acpi_attr_group = { 264 264 .attrs = acpi_attributes, 265 265 .is_visible = acpi_index_string_exist, 266 266 };